From owner-freebsd-rc@FreeBSD.ORG Tue Aug 11 00:01:36 2009 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E74A91065675; Tue, 11 Aug 2009 00:01:36 +0000 (UTC) (envelope-from ady@ady.ro) Received: from mail-ew0-f206.google.com (mail-ew0-f206.google.com [209.85.219.206]) by mx1.freebsd.org (Postfix) with ESMTP id 2E0CA8FC25; Tue, 11 Aug 2009 00:01:35 +0000 (UTC) Received: by ewy2 with SMTP id 2so3375555ewy.43 for ; Mon, 10 Aug 2009 17:01:35 -0700 (PDT) MIME-Version: 1.0 Sender: ady@ady.ro Received: by 10.211.199.11 with SMTP id b11mr5634837ebq.68.1249948894969; Mon, 10 Aug 2009 17:01:34 -0700 (PDT) In-Reply-To: <78cb3d3f0908101113s412021adk8956dd083a8fed72@mail.gmail.com> References: <4A7B2792.4090803@delphij.net> <4A7B487B.8060303@FreeBSD.org> <4A7F948A.2040602@delphij.net> <4A7F9EC6.9090605@FreeBSD.org> <4A7FAA42.4030607@delphij.net> <78cb3d3f0908101113s412021adk8956dd083a8fed72@mail.gmail.com> Date: Tue, 11 Aug 2009 02:01:34 +0200 X-Google-Sender-Auth: 916db593d9e98142 Message-ID: <78cb3d3f0908101701o6ea649cfk6a7d5e721d079866@mail.gmail.com> From: Adrian Penisoara To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-rc@freebsd.org, d@delphij.net Subject: Re: [RFC] script for binding ARP <-> IP pairs X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2009 00:01:37 -0000 Hi, On Mon, Aug 10, 2009 at 8:13 PM, Adrian Penisoara wrote: > Hi, > > On Mon, Aug 10, 2009 at 7:34 AM, Doug Barton wrote: > >> On Sun, 9 Aug 2009, Xin LI wrote: >> >> Hi, Doug, >>> >>> Doug Barton wrote: >>> >>>> Xin LI wrote: >>>> >>>> Thanks for your comments, I have put together the revised patch, along >>>>> with rc.conf.5 and defaults/rc.conf changes. >>>>> >>>> >>>> Glad to help. This looks fine except that you need an entry for >>>> static_arp_enable in defaults rc.conf and rc.conf.5. >>>> >>> >>> This script does not require the enable knob. If the static_arp_pairs >>> is not empty then the script would add the entries, otherwise it will >>> not do that. Do you think we need an "enable" knob for it? I can add >>> it but I don't feel strongly for the idea, since it would make a >>> redundant entry to represent the same semantic. >>> >> >> I missed the fact that you're not using rcvar. I'm sort of ambivalent >> about that, as I prefer things to be > > > I guess you could compare this to the cloned_interfaces rcvar... > > I stand corrected: it's rather more similar to the "static_routes / route_xxx" concept. I guess we have an entire class of such rc subroutines which are not $name_enable'd. Regards, Adrian.