Date: Mon, 14 Mar 2011 19:33:51 GMT From: Garrett Cooper <yanegomi@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/155558: [ports] qemu-devel broken on recent installs of CURRENT Message-ID: <201103141933.p2EJXpEQ050787@red.freebsd.org> Resent-Message-ID: <201103141940.p2EJeBxV067354@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 155558
>Category: ports
>Synopsis: [ports] qemu-devel broken on recent installs of CURRENT
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 14 19:40:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Garrett Cooper
>Release: CURRENT
>Organization:
>Environment:
FreeBSD bayonetta.local 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r218938M: Mon Feb 21 23:10:51 PST 2011 gcooper@bayonetta.local:/usr/obj/usr/src/sys/BAYONETTA amd64
>Description:
Since mdf's rototilling of SYSCTL(9) in r217586, emulators/*qemu* is failing to build with errors like this:
/usr/ports/emulators/qemu-devel/work/qemu-0.13.0/bsd-user/syscall.c: In function 'sysctl_oldcvt':
/usr/ports/emulators/qemu-devel/work/qemu-0.13.0/bsd-user/syscall.c:215: error: 'CTLTYPE_QUAD' undeclared (first use in this function)
/usr/ports/emulators/qemu-devel/work/qemu-0.13.0/bsd-user/syscall.c:215: error: (Each undeclared identifier is reported only once
/usr/ports/emulators/qemu-devel/work/qemu-0.13.0/bsd-user/syscall.c:215: error: for each function it appears in.)
What needs to happen is that the instance of CTLTYPE_QUAD needs to be replaced with CTLTYPE_U64:
$ grep -B 4 -A 4 _QUAD /usr/ports/emulators/qemu-devel/work/qemu-0.13.0/bsd-user/syscall.c
case CTLTYPE_ULONG:
*(uint64_t *)holdp = tswap64(*(unsigned long *)holdp);
break;
#endif
case CTLTYPE_QUAD:
*(uint64_t *)holdp = tswap64(*(uint64_t *)holdp);
break;
case CTLTYPE_STRING:
break;
>How-To-Repeat:
Upgrade to CURRENT r217586+ and try to build emulators/*qemu*.
>Fix:
Patch with an ifdef, like:
#if __FreeBSD_version__ < 900031
case CTLTYPE_QUAD:
#else
case CTLTYPE_U64:
#endif
Unfortunately mdf@ didn't bump __FreeBSD_version__ appropriately for the SYSCTL(9) KPI change.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103141933.p2EJXpEQ050787>