From owner-freebsd-mobile@FreeBSD.ORG Mon Jan 24 06:37:18 2005 Return-Path: Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E1DB116A4CF for ; Mon, 24 Jan 2005 06:37:18 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75FFB43D2D for ; Mon, 24 Jan 2005 06:37:18 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id j0O6Zk9S082873; Sun, 23 Jan 2005 23:35:46 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 23 Jan 2005 23:37:05 -0700 (MST) Message-Id: <20050123.233705.68307959.imp@bsdimp.com> To: bel@orel.ru From: "M. Warner Losh" In-Reply-To: <41F495FE.6000907@orel.ru> References: <41F02CE1.5090207@acm.org> <20050123.195438.61400112.imp@bsdimp.com> <41F495FE.6000907@orel.ru> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: freebsd-mobile@freebsd.org Subject: Re: Trouble with APM suspend in 5.3-R X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jan 2005 06:37:19 -0000 In message: <41F495FE.6000907@orel.ru> Andrew Belashov writes: : -----BEGIN PGP SIGNED MESSAGE----- : Hash: SHA1 : : Hello, Warner! : : M. Warner Losh wrote: : | In message: <41F02CE1.5090207@acm.org> : | Dave Walton writes: : | : Andrew Belashov wrote: : | : > Dave Walton wrote: : | : > : | : >> I've been unable to get APM suspend/resume to work with 5.3-R on my : | : >> Thinkpad 770Z. As released, 'apm -z' causes a lockup (it worked fine : | : >> in 4.x). Revision 1.233 of ata-all.c fixes that, and 'apm -z' now : | : >> causes the system to properly suspend to disk, as it had before. : | : >> However, when the system resumes, it spits out three errors regarding : | : >> pir0, then panics. This happens with or without your patch applied to : | : >> ata-all.c. : | : >> : | : > : | : > Try attached patch as workaround. : | : : | : A good effort! That is precisely the error I saw. Hopefully, that : | : removed call to pci_pir_biosroute() doesn't do anything important. : | : : | : Unfortunately, this had no effect at all on the panic. Please see my : | : next reply to Gleb Smirnoff for details on the panic. Perhaps it will : | : mean something to you. : | : | Chances are the right fix is to try the route, but ignore errors... : : I agree. But my old notebook recursively goes in cycles by calling : bios32(PCIBIOS_ROUTE_INTERRUPT) after resume. As result: kernel stack : overflow, double panic. : : BIOS update is not available. No known problems in Windows 2000 Pro. : : After removing call to pci_pir_biosroute(), suspend/resume works completely : on my notebook... This sounds like you disagree with me. I'm saying that one should call pci_pir_biosroute() anyway, and then ignore the return code. It sounds like you are saying that this call is fatal in a resume context.. Warner