Date: Sat, 20 Mar 2021 03:37:12 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r568794 - in head/multimedia/pipewire: . files Message-ID: <20210320033712.GA18472@FreeBSD.org> In-Reply-To: <CALH631krOy0fzL_V4Sz58z4TCFvEfKvqfCYbWCe=XpkTC99b5Q@mail.gmail.com> References: <202103191336.12JDaj8i012572@repo.freebsd.org> <20210319174447.GA16542@FreeBSD.org> <CALH631krOy0fzL_V4Sz58z4TCFvEfKvqfCYbWCe=XpkTC99b5Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 19, 2021 at 10:16:35PM +0300, Gleb Popov wrote: > On Fri, Mar 19, 2021 at 8:44 PM Alexey Dokuchaev <danfe@freebsd.org> wrote: > > On Fri, Mar 19, 2021 at 01:36:45PM +0000, Gleb Popov wrote: > > > New Revision: 568794 > > > URL: https://svnweb.freebsd.org/changeset/ports/568794 > > > > > > Log: > > > multimedia/pipewire: Fix a runtime crash. > > > > > > ... > > > @@ -0,0 +1,10 @@ > > > +--- src/daemon/pipewire.c.orig 2021-03-04 15:21:21 UTC > > > ++++ src/daemon/pipewire.c > > > +@@ -25,6 +25,7 @@ > > > + #include <limits.h> > > > + #include <signal.h> > > > + #include <getopt.h> > > > ++#include <libgen.h> > > > + > > > + #include <spa/utils/result.h> > > > + #include <pipewire/pipewire.h> > > > > Could you explain how adding a header file fixes a runtime crash? I could > > guess that it's e.g. because of a missing function prototype that returns > > a pointer or something ... > > Exactly this. Understood. Please try to write more elaborate commit logs next time, so everyone could easily see what's going on, not just you or me. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210320033712.GA18472>