From owner-freebsd-threads@FreeBSD.ORG  Tue May 12 11:12:49 2015
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2DD5C60A
 for <freebsd-threads@FreeBSD.org>; Tue, 12 May 2015 11:12:49 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 179C31D71
 for <freebsd-threads@FreeBSD.org>; Tue, 12 May 2015 11:12:49 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4CBCmtb067000
 for <freebsd-threads@FreeBSD.org>; Tue, 12 May 2015 11:12:48 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-threads@FreeBSD.org
Subject: [Bug 200138] [PATCH] Fixed sthread-specific array allocation
 conflict incurred in libthr by some foreign malloc libraries
Date: Tue, 12 May 2015 11:12:49 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: threads
X-Bugzilla-Version: 10.1-STABLE
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: kib@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-threads@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-200138-16-egZcEJyo86@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-200138-16@https.bugs.freebsd.org/bugzilla/>
References: <bug-200138-16@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads/>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
 <mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2015 11:12:49 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200138

--- Comment #10 from Konstantin Belousov <kib@FreeBSD.org> ---
(In reply to yuri from comment #8)
Requirements for the malloc interposers are established by the system source
code.  Third-party malloc library has to adhere to the constraints put by the
system, if the intent is to replace the system component.

I am saying that your statements do not make sense exactly because they do not
make sense.  The mere fact that a patch results in not printing a message, does
not make the patch valid.

That said, I think it would be more useful to ease the life of malloc(3)
interposers by avoiding the calloc call in the pthread_setspecific(3).  The
size of the thread-specific is around 1K per thread, which is almost free for
the userspace to carry together with the struct thread.  Non-trivial threading
programs would use explicit TLS for sure.

Try the patch I am attaching.  I change specific to be a part of the struct
thread, and also I cleaned style and removed false or trivial comments.

-- 
You are receiving this mail because:
You are the assignee for the bug.