From owner-cvs-src@FreeBSD.ORG Thu Jul 14 20:46:59 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9855516A41C; Thu, 14 Jul 2005 20:46:59 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 433F343D49; Thu, 14 Jul 2005 20:46:59 +0000 (GMT) (envelope-from imp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j6EKkxxt014245; Thu, 14 Jul 2005 20:46:59 GMT (envelope-from imp@repoman.freebsd.org) Received: (from imp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j6EKkxtk014244; Thu, 14 Jul 2005 20:46:59 GMT (envelope-from imp) Message-Id: <200507142046.j6EKkxtk014244@repoman.freebsd.org> From: Warner Losh Date: Thu, 14 Jul 2005 20:46:59 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/pccbb pccbb.c pccbb_pci.c pccbbvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2005 20:46:59 -0000 imp 2005-07-14 20:46:59 UTC FreeBSD src repository Modified files: sys/dev/pccbb pccbb.c pccbb_pci.c pccbbvar.h Log: Omnibus power and interrupt fixes: o Don't busy wait on powerup. Instead, use the power up interrupt to wait for the card to power up. Don't wait when we're turning the card off, since no interrupt happens in that case. o Convert many of the long DELAYs to tsleeps. We do not run before the timer have stared, so DELAY isn't necessary. More DELAYs can likely be eliminated in the future. o When powering up the card, don't do anything if the card is already powered up (before we'd power cycle it). This means that for most cards we power them up once and then never change the power. o On card eject, mask (by clearing) the CD bit. Before we set it, which was wrong. We don't want to see any CD events past the first one since they need to be debounced. With these changes, I can insert/eject 16bit cards without glitching xmms' sound output. Something very important to the development of better pccard drivers :-) Revision Changes Path 1.122 +73 -47 src/sys/dev/pccbb/pccbb.c 1.10 +1 -0 src/sys/dev/pccbb/pccbb_pci.c 1.24 +2 -1 src/sys/dev/pccbb/pccbbvar.h