From owner-freebsd-arch Sun May 7 3: 9:20 2000 Delivered-To: freebsd-arch@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 64D1237B774; Sun, 7 May 2000 03:09:15 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost.freebsd.dk [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.3) with ESMTP id MAA12217; Sun, 7 May 2000 12:08:29 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Greg Lehey Cc: "Justin T. Gibbs" , FreeBSD-arch@FreeBSD.ORG Subject: Re: Support for bootable Vinum file systems: please review In-reply-to: Your message of "Sun, 07 May 2000 17:46:39 +0930." <20000507174638.E55316@freebie.lemis.com> Date: Sun, 07 May 2000 12:08:29 +0200 Message-ID: <12215.957694109@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20000507174638.E55316@freebie.lemis.com>, Greg Lehey writes: >On Friday, 5 May 2000 at 12:52:33 +0200, Poul-Henning Kamp wrote: >> >>> I've been testing vinum root file systems for a couple of months now, >>> and I'd like to commit the code. I'm attaching the patches, which you >>> can also access at http://www.FreeBSD.org/~grog/vinum-root.html. >> >> It looks good, but I think using devstat to find possible disks is >> wrong. >> >> The right way to do it is probably to link the "struct disk"s >> registered by the drivers with disk_creat() into a list which can >> be searched. > >This is pretty much what struct devstat does, except that it's more >global. Why should we maintain two lists, just because one is >primarily intended for statistics? > >Anyway, I assume this isn't so much a criticism of the fix as of the >infrastructure around it. Correct? No, this is an objection to opening up devstat that way. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD coreteam member | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message