From owner-svn-src-all@FreeBSD.ORG Sun Oct 28 21:04:24 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 54E13B7B for ; Sun, 28 Oct 2012 21:04:24 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id A37938FC15 for ; Sun, 28 Oct 2012 21:04:23 +0000 (UTC) Received: (qmail 92784 invoked from network); 28 Oct 2012 22:41:25 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 28 Oct 2012 22:41:25 -0000 Message-ID: <508D9DD5.2080800@freebsd.org> Date: Sun, 28 Oct 2012 22:04:21 +0100 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf References: <201210262106.q9QL6YgY000943@svn.freebsd.org> <508BBE6C.7010409@freebsd.org> <20121027220137.GJ70741@FreeBSD.org> In-Reply-To: <20121027220137.GJ70741@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 21:04:24 -0000 On 28.10.2012 00:01, Gleb Smirnoff wrote: > On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote: > A> On 26.10.2012 23:06, Gleb Smirnoff wrote: > A> > Author: glebius > A> > Date: Fri Oct 26 21:06:33 2012 > A> > New Revision: 242161 > A> > URL: http://svn.freebsd.org/changeset/base/242161 > A> > > A> > Log: > A> > o Remove last argument to ip_fragment(), and obtain all needed information > A> > on checksums directly from mbuf flags. This simplifies code. > A> > o Clear CSUM_IP from the mbuf in ip_fragment() if we did checksums in > A> > hardware. Some driver may not announce CSUM_IP in theur if_hwassist, > A> > although try to do checksums if CSUM_IP set on mbuf. Example is em(4). > A> > A> I'm not getting your description here? Why work around a bug in a driver > A> in ip_fragment() when we can fix the bug in the driver? > > Well, that was actually bug in the stack and a very special driver that > demonstrates it. I may even agree that driver is incorrect, but the stack was > incorrect, too. Ah, OK. Do you intend to fix the driver as well? -- Andre