From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Mar 29 09:50:06 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56FBC16A4CE for ; Tue, 29 Mar 2005 09:50:06 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1579843D1F for ; Tue, 29 Mar 2005 09:50:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j2T9o5F3095003 for ; Tue, 29 Mar 2005 09:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j2T9o56q095002; Tue, 29 Mar 2005 09:50:05 GMT (envelope-from gnats) Date: Tue, 29 Mar 2005 09:50:05 GMT Message-Id: <200503290950.j2T9o56q095002@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Yen-Ming Lee Subject: Re: ports/79330: [PATCH] devel/p5-Module-Build: add .packlist in PLIST X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Yen-Ming Lee List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2005 09:50:06 -0000 The following reply was made to PR ports/79330; it has been noted by GNATS. From: Yen-Ming Lee To: freebsd-gnats-submit@FreeBSD.org, mat@FreeBSD.org, perl@FreeBSD.org Cc: Subject: Re: ports/79330: [PATCH] devel/p5-Module-Build: add .packlist in PLIST Date: Tue, 29 Mar 2005 17:44:43 +0800 --TRYliJ5NKNqkz5bu Content-Type: multipart/mixed; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=big5 Content-Disposition: inline On Tue, Mar 29, 2005 at 11:06:51AM +0200, Mathieu Arnold wrote: > I know about that, and I've been thinking on it hard. > > Your PR is just about as inapropriate as possible :-) > > because, if you fix it this way, you'll have to fix every other package > using Module::Build to build, because as it says it, "The default value is > true" meaning that every other port will have this .packlist. The correct > solution is either to use the previous version of the port for 5.4 release > (or to back it out), or to add a create_packlist=false in the appropriate > part of bsd.port.mk. Hmm.... I prefer to set create_packlist in bsd.port.mk BTW, I tried create_packlist=false and it didn't work like what I expected. We should use create_packlist=0 instead. Here comes the patch, and I guess this PR should be assigned to portmgr. -- Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=big5 Content-Disposition: attachment; filename="bsd.port.mk.diff" Index: bsd.port.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v retrieving revision 1.511 diff -u -r1.511 bsd.port.mk --- bsd.port.mk 17 Mar 2005 23:22:07 -0000 1.511 +++ bsd.port.mk 29 Mar 2005 09:36:54 -0000 @@ -1638,6 +1638,7 @@ ALL_TARGET?= PL_BUILD?= Build CONFIGURE_ARGS+= \ + create_packlist=0 \ install_path=lib="${PREFIX}/${SITE_PERL_REL}" \ install_path=arch="${PREFIX}/${SITE_PERL_REL}/${PERL_ARCH}" \ install_path=script="${PREFIX}/bin" \ --+QahgC5+KEYLbs62-- --TRYliJ5NKNqkz5bu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iQCVAwUBQkkji8nMx0NetS5RAQKV0wP+JKC364xlE8DdEZqUHFrqu5u5++MvJMsE Uqo/Z5jHJf6ZRfmk9oq0a2YBxTFgUQ6dsmi5OVSnZWR6j+IXFX71KOChGb+nFkG8 vCu4TW+wCKn3ngTzO4rnooVn9WeMH7KnPKPVRMymZG2GovsROJDXFHD5MXSWXIPy +Kz7OYT11no= =QIBw -----END PGP SIGNATURE----- --TRYliJ5NKNqkz5bu--