From owner-freebsd-ports@FreeBSD.ORG Mon Jul 8 06:52:45 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D4C36B39; Mon, 8 Jul 2013 06:52:45 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-we0-x234.google.com (mail-we0-x234.google.com [IPv6:2a00:1450:400c:c03::234]) by mx1.freebsd.org (Postfix) with ESMTP id 1D1AB1BAC; Mon, 8 Jul 2013 06:52:44 +0000 (UTC) Received: by mail-we0-f180.google.com with SMTP id w56so3291228wes.25 for ; Sun, 07 Jul 2013 23:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Rtdg9J1QfPOMZVGjS3TAhM8e23tH+6ufbvxWgfyTDok=; b=I+BkGkf1l9uxlPw6HJUEJfCgpQ0TrqQE7kWc+mVyC0hR2pfHDiFekUQDO6VE+zRplm RyXoH3cjAS17zJIlq5FGsZQF38HeEuOZK/CqYFMj47+A6bcNtfkeJZpIIbx8ReZsMQ1d iXAiBAmO+ISlxUkY0EPamMSHZEWkpBNfmmpi8J78uSyfJj/o0XqgklMEe9ONXQJ+4Ml9 4L7xBAKKXDBieTiU5eirqtKscUcdtpse5sqQzGEV/1AuXLtbxRA8xPwd5L8SjUud2dV5 pLTrgAaCLn4ZJdavJ35SGYDTqN9AW94sqrpD2yXWmh0hoTzcKkJD7RAZqvuXC3ViFcnJ CsOA== X-Received: by 10.180.106.163 with SMTP id gv3mr10780037wib.53.1373266363656; Sun, 07 Jul 2013 23:52:43 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id f8sm51672980wiv.0.2013.07.07.23.52.42 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 07 Jul 2013 23:52:42 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 8 Jul 2013 08:52:40 +0200 From: Baptiste Daroussin To: Andriy Gapon Subject: Re: port options are not saved in some ports Message-ID: <20130708065240.GC4078@ithaqua.etoilebsd.net> References: <51DA56C6.3030401@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vOmOzSkFvhd7u8Ms" Content-Disposition: inline In-Reply-To: <51DA56C6.3030401@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: kde@FreeBSD.org, freebsd-ports@FreeBSD.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jul 2013 06:52:45 -0000 --vOmOzSkFvhd7u8Ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 08, 2013 at 09:05:58AM +0300, Andriy Gapon wrote: >=20 > It seems that port options do not "stick" in the following ports: > ukrainian/kde4-l10n > russian/kde4-l10n >=20 > Could you please take a look? >=20 > --=20 > Andriy Gapon That is because misc/kde4-l10n/files/bsd.l10n.mk is totally wrong it does =2E.. =2Einclude =2E.. =2Einclude =2E.. =2Einclude First the right order in that case should be: =2E.. =2Einclude =2E.. =2Einclude =2E.. =2Einclude Second in that case (kde) The pre.mk/post.mk can be removed just keeping the options.mk and given that we now have the helpers options.mk can also be removed. The check for variables in OPTIONS_DEFINE is also useless (already done by = the framework) defining OPTIONS_DEFINE and OPTIONS_DEFAULT to some empty values is also useless. http://people.freebsd.org/~bapt/kde.diff now just replace bsd.port.post.mk in russian/kde4-l10n/Makefile by bsd.port= =2Emk and everything will work properly again. regards, Bapt --vOmOzSkFvhd7u8Ms Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlHaYbgACgkQ8kTtMUmk6Exr0ACfSXy+s0M6/+/vuuffvAR1p9Na 93sAn1QlWKZbNHBJ+VMRCdiHOG6d/8Um =qVIJ -----END PGP SIGNATURE----- --vOmOzSkFvhd7u8Ms--