Date: Tue, 16 Apr 2019 04:07:01 +0000 From: bugzilla-noreply@freebsd.org To: elastic@FreeBSD.org Subject: [Bug 229322] net/py-urllib3: Update to 1.24.1 Message-ID: <bug-229322-37421-WSwCUcK1Xw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-229322-37421@https.bugs.freebsd.org/bugzilla/> References: <bug-229322-37421@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229322 --- Comment #16 from commit-hook@freebsd.org --- A commit references this bug: Author: koobs Date: Tue Apr 16 04:06:27 UTC 2019 New revision: 499073 URL: https://svnweb.freebsd.org/changeset/ports/499073 Log: textproc/py-elasticsearch5: Remove pinned urllib3 version elasticsearch5 (this port) unnecessarily pins its urllib dependency to < 1.23, which blocks updating urllib3 to 1.24 [1]: ./textproc/py-elasticsearch5: setup.py: 'urllib3<1.23,>=3D1.21.1', The package had a history of issues/conflicts/bugs with the urllib3 dependency, ultimately resulting in the maximum version pin being removed [2]: https://github.com/elastic/elasticsearch-py/issues/807 https://github.com/elastic/elasticsearch-py/issues/667 https://github.com/elastic/elasticsearch-py/issues/634 This commit backports that change, a functional noop and sweeping change in advance required for a urllib3 update, and adds TEST_DEPENDS and a test target to support rigorous and confident QA. Switching to GitHub sources was required as the PyPI sdist does not package tests. The packages tests all pass with/against urllib3 1.24 installed, with an intermittent and non-deterministic off-by-one failure in one test: FAIL: test_all_chunks_sent (test_elasticsearch.test_helpers.TestParallelB= ulk) The issue exists independent of urllib3 version. The flaky test issue was reported upstream [3], but was not resolved. [2] https://github.com/elastic/elasticsearch-py/commit/4352e56174b77560d2f86801= cb1ad32440bb2d32 [3] https://github.com/elastic/elasticsearch-py/issues/701 PR: 229322 [1] Approved by: portmgr (blanket: framework compliance, runtime bugfix) Changes: head/textproc/py-elasticsearch5/Makefile head/textproc/py-elasticsearch5/distinfo head/textproc/py-elasticsearch5/files/ head/textproc/py-elasticsearch5/files/patch-setup.py --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229322-37421-WSwCUcK1Xw>