From owner-freebsd-ports@FreeBSD.ORG  Thu Mar  1 12:38:02 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B6B9F1065670;
	Thu,  1 Mar 2012 12:38:02 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com
	[209.85.210.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 685808FC0A;
	Thu,  1 Mar 2012 12:38:02 +0000 (UTC)
Received: by iahk25 with SMTP id k25so991430iah.13
	for <multiple recipients>; Thu, 01 Mar 2012 04:38:01 -0800 (PST)
Received-SPF: pass (google.com: domain of utisoft@gmail.com designates
	10.50.178.38 as permitted sender) client-ip=10.50.178.38; 
Authentication-Results: mr.google.com;
	spf=pass (google.com: domain of utisoft@gmail.com
	designates 10.50.178.38 as permitted sender)
	smtp.mail=utisoft@gmail.com;
	dkim=pass header.i=utisoft@gmail.com
Received: from mr.google.com ([10.50.178.38])
	by 10.50.178.38 with SMTP id cv6mr537927igc.1.1330605481995 (num_hops =
	1); Thu, 01 Mar 2012 04:38:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=lB/5VScZsDIAUkaYq8S6wGJsImR0Ab9JMuZSuzCelW4=;
	b=N9EzOuixxaryGuO3CAtiZ562Q1HcHFXp57XT9ZPymnRjXyxzDHu19p5ezhqcapykp2
	BVCn1lTRu+dWrIqdcZ6AlQNrz90NPSheiRQlS6392VJWLo6GwkCM1uCoo3ojsneZFVtx
	pVa/CPYEzXu9PWCKD3VJbjVYxYeRwzyupiBOU=
MIME-Version: 1.0
Received: by 10.50.178.38 with SMTP id cv6mr435708igc.1.1330605481938; Thu, 01
	Mar 2012 04:38:01 -0800 (PST)
Received: by 10.231.155.20 with HTTP; Thu, 1 Mar 2012 04:38:01 -0800 (PST)
Received: by 10.231.155.20 with HTTP; Thu, 1 Mar 2012 04:38:01 -0800 (PST)
In-Reply-To: <4F4F5C76.8040908@FreeBSD.org>
References: <4F4F5C76.8040908@FreeBSD.org>
Date: Thu, 1 Mar 2012 12:38:01 +0000
Message-ID: <CADLo83-9TZWG9C7N0169HxxRJtPgAAvcYhA2UXQ2GpSNxGHkHw@mail.gmail.com>
From: Chris Rees <utisoft@gmail.com>
To: Matthew Seaman <matthew@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: freebsd-ports <freebsd-ports@freebsd.org>
Subject: Re: On the usage of ${FILE}
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Mar 2012 12:38:02 -0000

On 1 Mar 2012 11:26, "Matthew Seaman" <matthew@freebsd.org> wrote:
>
>
> Dear all,
>
> bsd.commands.mk has the following:
>
> FILE?=          /usr/bin/file
>
> which is unfortunate, given that ${FILE} is used in several thousand
> ports, generally as a loop control variable for iterating through a list
> of files. In fact, I can only find about 8 places where the file(1)
> program is intended.
>
> This obvious conflict of meanings seems pretty undesirable to me.  Am I
> missing something?  Is there any reason to keep the status quo rather
> than changing the bsd.commands.mk variable to FILE_CMD and making the
> corresponding changes in those 8 places?
>
>        Cheers,
>
>        Matthew
>

I think that the loop control variables should be renamed to lower case.

Chris