From nobody Wed Dec 13 16:49:31 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sr1fh05Wpz541Tx; Wed, 13 Dec 2023 16:49:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sr1fg6jXyz3fTR; Wed, 13 Dec 2023 16:49:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702486171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LabRJFmg/FWZzANsQfXlAo8yKepB7v8hMvDsqR2wq9s=; b=xLidUK0yVos78wRHEukGL2LgMgZdiXeey5oIK5czJIH77eiju+rBuLJyEq5mv/lnswBH8y ywtiFR3GW0KYyK2x7xa721xZ1rFh1Nbg5AZB9PC5jHj+5CREwMl49Nb+iPIYZIwJCAJQp4 6KkXEhG+BQ/yEkLbNTxGsLFCbeqfBRbNhpgauB2obQIU3D6fWpHZ0yyYiKm1hL12FEp0jb 508UvaIk72ORpVkZxsoC6gdZl7SuTiK2r+igCEyx/ixT9MJa7TWxQpiseLYci0c1/Skq+V 71sKWcyoBdAoV6ncoIjShdrgmtZCkgsMxaleOpzqXfBBXoWfcmyfoq6zHbH86w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1702486171; a=rsa-sha256; cv=none; b=oLTN0pHZC0k8f012PeB4KCo7KMQEg5kRZAJQ/RBiXIgU19ak3WkVh4KaUlx0KGCky0aoQo Wnru6/df1B4iXtaaqgGcnI+dMRu6dSTOxQGHa08sDiobjmyJieAkRWY9rJLVSbFHE/XcZN zf+93wIfTDn5FZozFuDdHbLt9Xb6QXWPGAN15kPWjXgH6CrLp5NOhs/SHIIQkQCA5fzxnI PswVXn2F0+GpTOc4LUU/n9yxhibQ8b0oLflSCnsLX4KxeJTeHnKRkQRKtdZFtJpHayMLFC 9ve3zOWj1J945H+jLhqyzDW7s6L97gWtrhdbaT4PTJeDE6aDNAEA6th4+8Qggg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702486171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LabRJFmg/FWZzANsQfXlAo8yKepB7v8hMvDsqR2wq9s=; b=PALYuSmJvP33jPagTsHz+GA0ubuLFiLFACTeVHzcM2JT5eMVs49Bz085DA40FUSQ1c465V vvIVbL74nfA6gtNiE2FFoxJTyz0gy2MuxR0naYBu5UOrO3Z0bBdaHBSJOVCfzUJYMlBJY2 5rlPCth1WTEHAFmph0zEoIJyZPeBHkOci0AFny2M7AN/vxtcLBHd23E4GOrWuwC+L+jRhZ /ERvuDCFdHVGplGu85YQby40mk4SxswbKkNCFMc0DOGyCeuAdnxc6s309m1LHyPwjQEvGD JL9/0whm326EaiRfjaIcU8DGO2LEUReIiHDEX3XakKIsh7n3Lz43nD9H8b6Ygg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sr1fg5ntfz1612; Wed, 13 Dec 2023 16:49:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3BDGnVcF050659; Wed, 13 Dec 2023 16:49:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3BDGnVNr050656; Wed, 13 Dec 2023 16:49:31 GMT (envelope-from git) Date: Wed, 13 Dec 2023 16:49:31 GMT Message-Id: <202312131649.3BDGnVNr050656@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: a206524709bd - main - kdump: use print_mask_arg0 appropriately List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a206524709bdfbd577bcfe76676da80b8250f84c Auto-Submitted: auto-generated The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=a206524709bdfbd577bcfe76676da80b8250f84c commit a206524709bdfbd577bcfe76676da80b8250f84c Author: Kyle Evans AuthorDate: 2023-12-13 16:49:03 +0000 Commit: Kyle Evans CommitDate: 2023-12-13 16:49:03 +0000 kdump: use print_mask_arg0 appropriately Some callers are using print_mask_arg() when they should be using print_mask_arg0(); the latter should be used when all flags are optional and there's not a flag to be decoded with a 0-mask. This turns: nmount(0x6991e009000,0x8,0<>0) into: nmount(0x6991e009000,0x8,0) Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D43007 --- usr.bin/kdump/kdump.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/usr.bin/kdump/kdump.c b/usr.bin/kdump/kdump.c index ce68f4522e0f..0253fdc9e87b 100644 --- a/usr.bin/kdump/kdump.c +++ b/usr.bin/kdump/kdump.c @@ -922,7 +922,8 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_close_range_flags, *ip); + print_mask_arg0(sysdecode_close_range_flags, + *ip); ip += 3; narg -= 3; break; @@ -988,14 +989,14 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break; case SYS_unmount: print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break; @@ -1453,7 +1454,7 @@ ktrsyscall_freebsd(struct ktr_syscall *ktr, register_t **resip, print_number(ip, narg, c); print_number(ip, narg, c); putchar(','); - print_mask_arg(sysdecode_mount_flags, *ip); + print_mask_arg0(sysdecode_mount_flags, *ip); ip++; narg--; break;