From owner-freebsd-hackers@FreeBSD.ORG Fri Dec 16 21:47:40 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A94AE16A41F; Fri, 16 Dec 2005 21:47:40 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id AB27043D82; Fri, 16 Dec 2005 21:47:37 +0000 (GMT) (envelope-from dunstan@freebsd.czest.pl) Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4]) by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id jBGLo3Px058834; Fri, 16 Dec 2005 21:50:04 GMT (envelope-from dunstan@freebsd.czest.pl) Received: (from dunstan@localhost) by freebsd.czest.pl (8.13.4/8.12.9/Submit) id jBGLo3iI058833; Fri, 16 Dec 2005 21:50:03 GMT (envelope-from dunstan) Date: Fri, 16 Dec 2005 21:50:02 +0000 From: "Wojciech A. Koszek" To: Peter Jeremy Message-ID: <20051216215002.GA58739@FreeBSD.czest.pl> References: <20051215223745.GA37768@FreeBSD.czest.pl> <20051216091057.GQ77268@cirb503493.alcatel.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline In-Reply-To: <20051216091057.GQ77268@cirb503493.alcatel.com.au> User-Agent: Mutt/1.4.2.1i Cc: freebsd-hackers@freebsd.org, phk@freebsd.org Subject: Re: [CALL FOR TESTERS] New system call: abort2() X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2005 21:47:40 -0000 On Fri, Dec 16, 2005 at 08:10:57PM +1100, Peter Jeremy wrote: > On Thu, 2005-Dec-15 22:37:45 +0000, Wojciech A. Koszek wrote: > > abort2(const char *why, int nargs, void **args); > > > >"why" is reason of program abort, "nargs" is number of arguments > >passed in "args". Both "why" and "args" (with "%p" format) will be > >printed via log(9). Sample output: > >[..] > >pid <3004> abort2: ABORT2 > >pid <3019> abort2: invalid argument > >[..] > > I don't believe the following code is correct. uap->args is a > userspace pointer so uap->args[i] is dereferencing a userspace > argument in kernelspace. > + arg = uargs[i] = (void *) fuword(uap->args[i]); > I think it should be fuword(uap->args + i); > > I don't see the point of the following test. "arg" is printed using > %p and never de-referenced so there's no reason it can't be NULL. I > would see that a legitimate use of abort2() is when the application > detects that a pointer is unexpectedly NULL. Aborting on -1 is less > clear - if fuword() fails, it will return -1 but, equally, a faulty > user application may have left -1 in a pointer. (Note that mmap(2) > returns -1 on error so it's not inconceivable that a pointer could > contain -1). > > + /* Prevent from faults in user-space */ > + if (arg == NULL || arg == (void *)-1) { > + error = EINVAL; > + break; > + } > > Taking the above into account, I believe the code should be: > + if (uap->args == NULL) > + break; > + error = copyin(uap->args, uargs, uap->nargs * sizeof (void *)); > + if (error != 0) > + break; Of course! Thanks for this comment! Updated version should be available soon. -- * Wojciech A. Koszek && dunstan@FreeBSD.czest.pl