From owner-freebsd-hackers@FreeBSD.ORG Wed May 29 16:18:30 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 906C87BF for ; Wed, 29 May 2013 16:18:30 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ob0-x235.google.com (mail-ob0-x235.google.com [IPv6:2607:f8b0:4003:c01::235]) by mx1.freebsd.org (Postfix) with ESMTP id 5C24A79D for ; Wed, 29 May 2013 16:18:30 +0000 (UTC) Received: by mail-ob0-f181.google.com with SMTP id 16so1530007obc.12 for ; Wed, 29 May 2013 09:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=dOu5gNj0ilH11mfk3tU7MIay/9VDj4IEz6DUqd95NAM=; b=co0UtEitIQiw+nr2+O2IcVz+PJTcYgoyhsdGJaH/pqAz0uenMVHqw3t7RZDqg2I1iL 0auL6gYcIVJVyTTtCAsPH2uVpdJn95W6Fj/wXbRsCmPbq15El3N82G/fmwNEYJhSyUjn Ohsp/ZJDigPEUruiHdF6jctRQhZYIYC5A0F3v0rX4YZbJKu8vecnz4NCaJVLCtG2LNc5 4ENV52uaXo4CoVVySSeN2P8cY3FCJyU4lRv1VEXRH8paV1Hoov/8lM6AsEdJuBdkh0yv Gnd/fOMmzyht8PWD2YN9pUPrrCnge03RC/OEsbeW/NtUVbj8PfRfOQkm/Mim7hNzmCs6 ER5Q== X-Received: by 10.60.36.136 with SMTP id q8mr2057221oej.90.1369844309874; Wed, 29 May 2013 09:18:29 -0700 (PDT) Received: from monkey-bot.int.fusionio.com ([209.117.142.2]) by mx.google.com with ESMTPSA id x10sm41549472oes.6.2013.05.29.09.18.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 May 2013 09:18:28 -0700 (PDT) Sender: Warner Losh Subject: Re: Order of canonical upgrade sequence Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Wed, 29 May 2013 10:18:26 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <05285081-3881-4AD7-8F17-EF919F2A0076@bsdimp.com> References: To: Chris Rees X-Mailer: Apple Mail (2.1085) X-Gm-Message-State: ALoCoQnrZIoYckuwGXj1Q4NVpOKmVkOIjX0DKQOZeltDwooT2t8n0X6O6tmTg/fLuitHCt2UZzVu Cc: "freebsd-hackers@freebsd.org" , Alexander Leidinger , Glen Barber X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 May 2013 16:18:30 -0000 On May 29, 2013, at 10:02 AM, Chris Rees wrote: > Hi all! >=20 > Back in 2005, when Alexander Leidinger wrote the make delete-old > target, he documented the order of upgrade such that it should be run > before mergemaster [1]; >=20 > # 7. `make installworld' > # 8. `make delete-old' > # 9. `mergemaster' >=20 > I have merged the delete-old section of the Handbook into the > upgrading chapter, and independently decided to put mergemaster first, > because I thought it would be safer, but checked here before I > committed. >=20 > I think that steps 8 and 9 should be reversed, because of the > possibility of an unbootable system being made, when an rc script > references an executable that has just been removed for example. While I don't care, any old scripts that are removed won't make the = system unbootable. delete-old deletes both the executable and the rc = script in those cases where we've moved functionality out of the base = system. The rc scripts themselves have protection against executables = not found, and the damage will be limited to at most the one script that = references that binary. Since the binary is gone, the ill effects are = minimal. So I'm finding it hard to believe this is a credible example of danger. > I cannot think of an example where the system is left > unbootable/damaged if make delete-old is run after mergemaster. I'm not sure that it will be that much safer, but to be honest, I run = delete-old about once every presidential election cycle on my machines. > What do people think of the patch at [2]? It's likely a tiny bit safer, but I don't think it is necessary. Warner > Chris >=20 > [1] http://svnweb.freebsd.org/base/head/Makefile?r1=3D148329&r2=3D148330= & >=20 > [2] http://www.bayofrum.net/~crees/patches/delete-old-order.diff