From owner-freebsd-stable@FreeBSD.ORG Fri Jun 23 05:17:50 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A958F16A482 for ; Fri, 23 Jun 2006 05:17:50 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D45543D49 for ; Fri, 23 Jun 2006 05:17:50 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k5N5ESXs031131; Thu, 22 Jun 2006 23:14:28 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 22 Jun 2006 23:14:28 -0600 (MDT) Message-Id: <20060622.231428.790460912.imp@bsdimp.com> To: doconnor@gsoft.com.au From: "M. Warner Losh" In-Reply-To: <200606231104.31514.doconnor@gsoft.com.au> References: <200606221424.14380.doconnor@gsoft.com.au> <200606221323.01249.pieter@degoeje.nl> <200606231104.31514.doconnor@gsoft.com.au> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: pieter@degoeje.nl, freebsd-stable@freebsd.org Subject: Re: Asus A8V IRQ/serial problems X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2006 05:17:50 -0000 In message: <200606231104.31514.doconnor@gsoft.com.au> "Daniel O'Connor" writes: : I think a better option would be to remove the test in sio.c for the AMD64 : case since isa_irq_pending() won't do anything. I hate #ifdef __amd64__ code. It is evil and should be avoided. Maybe the right answer is to have a separate ACPI probe routine that does something similar to the pccard case where we pass 'noprobe = 1' to the sioprobe routine. If ACPI says there's a sio there, we don't need to probe for it... Warner