Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Jun 2006 23:14:28 -0600 (MDT)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        doconnor@gsoft.com.au
Cc:        pieter@degoeje.nl, freebsd-stable@freebsd.org
Subject:   Re: Asus A8V IRQ/serial problems
Message-ID:  <20060622.231428.790460912.imp@bsdimp.com>
In-Reply-To: <200606231104.31514.doconnor@gsoft.com.au>
References:  <200606221424.14380.doconnor@gsoft.com.au> <200606221323.01249.pieter@degoeje.nl> <200606231104.31514.doconnor@gsoft.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200606231104.31514.doconnor@gsoft.com.au>
            "Daniel O'Connor" <doconnor@gsoft.com.au> writes:
: I think a better option would be to remove the test in sio.c for the AMD64 
: case since isa_irq_pending() won't do anything.

I hate #ifdef __amd64__ code.  It is evil and should be avoided.
Maybe the right answer is to have a separate ACPI probe routine that
does something similar to the pccard case where we pass 'noprobe = 1'
to the sioprobe routine.  If ACPI says there's a sio there, we don't
need to probe for it...

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060622.231428.790460912.imp>