Date: Mon, 18 Sep 2006 21:25:58 +0200 From: "Simon L. Nielsen" <simon@FreeBSD.org> To: Shaun Amott <shaun@FreeBSD.org> Cc: freebsd-www@FreeBSD.org Subject: Re: RFC: New GNATS web (query-pr.cgi) interface Message-ID: <20060918192557.GE1038@zaphod.nitro.dk> In-Reply-To: <20060917223229.GA1304@picobyte.net> References: <20060912201245.GA1915@picobyte.net> <20060917190419.GC33937@zaphod.nitro.dk> <20060917223229.GA1304@picobyte.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--ctP54qlpMx3WjD+/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2006.09.17 23:32:29 +0100, Shaun Amott wrote: > On Sun, Sep 17, 2006 at 09:04:20PM +0200, Simon L. Nielsen wrote: > > The main thing which I think should be done before commit is use of > > cgi-style.pl. While it might seem unnecessary now, it really is much > > nicer for the people maintaing the website if there are as few places > > as possible where we need to change if modifications are made to the > > layout. Also, the script currently doesn't totally match the style of > > the rest of the FreeBSD.org web site, which I suspect is related to it > > not using cgi-style.pl. >=20 > Yes, the style is a vast improvement over the mess we have in place now. > But for the sake of consistency, I have switched to using cgi-style.pl. Great, thanks! > Hopefully, some of the improvements between the old style and mine can > be merged across the site at some point. But that's another discussion. Most of the CGI scripts could use some cleanup after having been in service for ~10 years... > > One other issue which also need to be fixed is that the script don't > > work with perl 5.0, which is still requires for a bit. >=20 > I've hacked out the modern Perl bits and pieces, it now runs on 5.0. Good, when we (hopefully soon) move to perl 5.8 on www.freebsd.org the code can be readded. > > The last thing I can think of now is that the script should use taint > > mode like shown below, just in case. >=20 > Indeed - I intended to add it anyway. Great again :-). I reviewed the changes to freefall:~shaun/public_html/stuff/gnatsweb.final/query-pr.txt and it looks good, so I it should just be committed and you can use rubber stamp (IE. Approved by me.). I also put it online on www.freebsd.org and it works fine. I'm not going to publish the URL here since I'm going to delete the script =66rom the temp location again soon. I assume you know how to add the CSS to the Makefile without breaking the build, but feel free to poke me if you have any question in that regard. --=20 Simon L. Nielsen --ctP54qlpMx3WjD+/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFDvLFNE7ltJU9KiERArMPAJ0X8EcqjK7X6pkKO2wDoCRbqo3IkACgi51x L8aSHaPj0TtUK1Le7EWhytI= =Lah5 -----END PGP SIGNATURE----- --ctP54qlpMx3WjD+/--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060918192557.GE1038>