From owner-freebsd-stable@FreeBSD.ORG  Sat Apr  7 07:53:41 2012
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 83212106566B
	for <freebsd-stable@freebsd.org>; Sat,  7 Apr 2012 07:53:41 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84])
	by mx1.freebsd.org (Postfix) with ESMTP id 380FA8FC1A
	for <freebsd-stable@freebsd.org>; Sat,  7 Apr 2012 07:53:41 +0000 (UTC)
Received: from pampa.cs.huji.ac.il ([132.65.80.32])
	by kabab.cs.huji.ac.il with esmtp
	id 1SGQSp-0003Lv-DK; Sat, 07 Apr 2012 10:53:39 +0300
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.3
To: Marius Strobl <marius@alchemy.franken.de>
In-reply-to: <20120406171644.GA9162@alchemy.franken.de>
References: <E1SG3u1-000Ian-Te@kabab.cs.huji.ac.il> 
	<20120406171644.GA9162@alchemy.franken.de>
Comments: In-reply-to Marius Strobl <marius@alchemy.franken.de>
	message dated "Fri, 06 Apr 2012 19:16:44 +0200."
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Sat, 07 Apr 2012 10:53:39 +0300
From: Daniel Braniss <danny@cs.huji.ac.il>
Message-ID: <E1SGQSp-0003Lv-DK@kabab.cs.huji.ac.il>
Cc: freebsd-stable@freebsd.org
Subject: Re: 8.3-PRERELEASE and ATA_CAM
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Apr 2012 07:53:41 -0000

> On Fri, Apr 06, 2012 at 10:48:13AM +0300, Daniel Braniss wrote:
> > with the latest svn, I can't compile kernel with  options ATA_CAM:
> > 
> > ...
> > linking kernel.debug
> > ata-disk.o(.text+0x93): In function `ad_init':
> > /r+d/stable/8.3/sys/dev/ata/ata-disk.c:389: undefined reference to 
> > `ata_setmode'
> > ata-disk.o(.text+0xaa):/r+d/stable/8.3/sys/dev/ata/ata-disk.c:397: undefined 
> > reference to `ata_wc'
> > ata-disk.o(.text+0xc5):/r+d/stable/8.3/sys/dev/ata/ata-disk.c:398: undefined 
> > reference to `ata_controlcmd'
> > ata-disk.o(.text+0x113):/r+d/stable/8.3/sys/dev/ata/ata-disk.c:400: undefined 
> > reference to `ata_controlcmd'
> > ata-disk.o(.text+0x133):/r+d/stable/8.3/sys/dev/ata/ata-disk.c:393: undefined 
> > reference to `ata_controlcmd'
> > ata-disk.o(.text+0x16d):/r+d/stable/8.3/sys/dev/ata/ata-disk.c:407: undefined 
> > reference to `ata_controlcmd'
> > ata-disk.o(.text+0x21a): In function `ad_shutdown':
> > /r+d/stable/8.3/sys/dev/ata/ata-disk.c:196: undefined reference to 
> > `ata_controlcmd'
> > ata-disk.o(.text+0x45c): In function `ad_detach':
> > /r+d/stable/8.3/sys/dev/ata/ata-disk.c:182: undefined reference to 
> > `ata_fail_requests'
> > ...
> > 
> 
> You seem to be using a mutually exclusive set of ata(4) options and
> devices (previously, this erroneously wasn't a bug). When including
> options ATA_CAM you do _not_ want to also include any of the following
> devices:
> device		atapicam
> device		atadisk
> device		ataraid
> device		atapicd
> device		atapifd
> device		atapist
> 
> Instead you need the corresponding driver from the following set:
> device		scbus
> device		ch
> device		da
> device		sa
> device		cd
> device		pass
> 
> Marius
> 
they are included by GENERIC, which i include, bummer.
what about ATA_STATIC_ID, I guess that is also a nono? 
thanks,
	danny