From owner-freebsd-current@FreeBSD.ORG  Fri Jan 18 13:20:01 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 8B452E63;
 Fri, 18 Jan 2013 13:20:01 +0000 (UTC) (envelope-from jh@FreeBSD.org)
Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi
 [195.197.172.116])
 by mx1.freebsd.org (Postfix) with ESMTP id 4C30E7D3;
 Fri, 18 Jan 2013 13:20:01 +0000 (UTC)
Received: from a91-153-116-96.elisa-laajakaista.fi
 (a91-153-116-96.elisa-laajakaista.fi [91.153.116.96])
 by gw02.mail.saunalahti.fi (Postfix) with SMTP id 0C997139811;
 Fri, 18 Jan 2013 15:19:55 +0200 (EET)
Date: Fri, 18 Jan 2013 15:19:54 +0200
From: Jaakko Heinonen <jh@FreeBSD.org>
To: Alexander Motin <mav@FreeBSD.org>
Subject: Re: panic after r244584
Message-ID: <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi>
References: <20130118073600.GA70874@hell.ukr.net>
 <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org>
 <20130118113934.GA60441@hell.ukr.net>
 <50F9357F.8040109@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50F9357F.8040109@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: satan@ukr.net, Gleb Smirnoff <glebius@FreeBSD.org>,
 freebsd-current@FreeBSD.org
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jan 2013 13:20:01 -0000

On 2013-01-18, Alexander Motin wrote:
> > AM> > V>  panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7)

> > AM> The panic is triggered by the check added by the recent r244584 change.
> > AM> The space in device name came from the enclosure device, and I guess it
> > AM> may be quite often situation. Using human readable name supposed to help
> > AM> system administrators, but with spaces banned that may be a problem.
> > 
> > That's was not created by human, it was generated (I think so) by system. 
> 
> These strings are flashed into enclosure firmware by manufacturer.

You can't rely on that any string can be safely used as a device name
even if spaces were allowed. Consider for example duplicate names and
"../".

Where these names are generated? The original report didn't contain a
backtrace.

-- 
Jaakko