From owner-freebsd-bugs Thu Nov 18 7:37:55 1999 Delivered-To: freebsd-bugs@freebsd.org Received: from cichlids.com (as3-050.rp-plus.de [149.221.238.242]) by hub.freebsd.org (Postfix) with ESMTP id 45BC8150EF for ; Thu, 18 Nov 1999 07:37:47 -0800 (PST) (envelope-from alex@cichlids.com) Received: from cichlids.cichlids.com (cichlids.cichlids.com [192.168.0.10]) by cichlids.com (Postfix) with ESMTP id 371C2AB7F; Thu, 18 Nov 1999 15:27:24 +0100 (CET) Received: (from alex@localhost) by cichlids.cichlids.com (8.9.3/8.9.3) id PAA00591; Thu, 18 Nov 1999 15:27:17 +0100 (CET) (envelope-from alex) From: Alexander Langer Date: Thu, 18 Nov 1999 15:27:16 +0100 To: okimoto@mrit.mei.co.jp Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: bin/14920: install(1) hangs when intalling files same directory. Message-ID: <19991118152716.A521@cichlids.cichlids.com> References: <199911181140.DAA22075@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <199911181140.DAA22075@freefall.freebsd.org>; from okimoto@mrit.mei.co.jp on Thu, Nov 18, 1999 at 03:40:01AM -0800 X-PGP-Fingerprint: 44 28 CA 4C 46 5B D3 A8 A8 E3 BA F3 4E 60 7D 7F X-Verwirrung: Dieser Header dient der allgemeinen Verwirrung. Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Thus spake okimoto@mrit.mei.co.jp (okimoto@mrit.mei.co.jp): > He said this problem was 3.3-RELEASE case. But, > install(1) should detect if the source-file is the > same as the destination file, he also thought. > So, he made a patch for "xinstall.c", and it's good. Hello! Actually, I'm redoing the patch, because it's not that good as it seems. Additionally, I found a strange bug: root:/usr/src/usr.bin/xinstall $ install /dev/null /usr/home install: /dev/null: Inappropriate file type or format xinstall.c includes /* If try to install NULL file to a directory, fails. */ if (flags & DIRECTORY || strcmp(from_name, _PATH_DEVNULL)) { The part in this brackets does not look senseful for me. It should be (flags & DIRECTORY && strcmp(from_name, _PATH_DEVNULL) == 0), at least with the stuff inside the brackets. I'll redo this, too. Alex -- I doubt, therefore I might be. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message