From owner-freebsd-hackers Tue Jun 23 14:09:16 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA07180 for freebsd-hackers-outgoing; Tue, 23 Jun 1998 14:09:16 -0700 (PDT) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA07170; Tue, 23 Jun 1998 14:09:12 -0700 (PDT) (envelope-from michaelh@cet.co.jp) Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.8/CET-v2.2) with SMTP id VAA24565; Tue, 23 Jun 1998 21:07:19 GMT Date: Wed, 24 Jun 1998 06:07:19 +0900 (JST) From: Michael Hancock To: Terry Lambert cc: Matthew.Alton@anheuser-busch.com, FreeBSD-fs@FreeBSD.ORG, Hackers@FreeBSD.ORG, Scott.Smallie@anheuser-busch.com Subject: Re: Stackable filesystems and SunOS 4.1.1 In-Reply-To: <199806230354.UAA06135@usr09.primenet.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 23 Jun 1998, Terry Lambert wrote: > Do I have to proxy the grotesqueries that are the cookie interface, > instead of spliting the directory lookup, directory entry copyout, > the nameifree() asymmetry, etc.? Then it's about twice the work. I agree that the way the path buf is being freed is bogus. This becomes obvious when you look at vop_abortop implementations for ffs, ext2fs, etc. IMHO, if you freshen up your nameifree() patches without changing goto label names, exit points, whitespace style, and variables names in the FreeBSD source base; then you will have a better chance of getting the code committed. It makes it easier to review the patches and it will also be easier to track enhancements from other BSDs if you do it this way. Also, I think testset was a pretty cool tool for testing these changes. Did you port it to current? I used this as a base for testvn. Check out ~mch on freefall. Regards, Mike Hancock To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message