From owner-freebsd-toolchain@FreeBSD.ORG Fri May 27 17:38:03 2011 Return-Path: Delivered-To: freebsd-toolchain@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 736461065672; Fri, 27 May 2011 17:38:03 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 2FD678FC0A; Fri, 27 May 2011 17:38:03 +0000 (UTC) Received: from [10.30.101.53] ([209.117.142.2]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p4RHLKUt056377 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Fri, 27 May 2011 11:21:24 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20110527115147.GA73802@freebsd.org> Date: Fri, 27 May 2011 11:21:14 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <3BF63174-1B29-4A4D-96DD-3ED65ED96EAC@bsdimp.com> References: <20110527115147.GA73802@freebsd.org> To: Alexander Best X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Fri, 27 May 2011 11:21:24 -0600 (MDT) Cc: freebsd-hackers@FreeBSD.ORG, freebsd-toolchain@FreeBSD.ORG Subject: Re: [rfc] a few kern.mk and bsd.sys.mk related changes X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2011 17:38:03 -0000 These look generally good. Just one thing I had a question on: # +# Enable FreeBSD kernel-specific printf format specifiers. Also = instruct gcc to +# enable some diagnostics, which make it easier to pinpoint tinderbox = failures. +CFLAGS+=3D -fformat-extensions -fdiagnostics-show-option + Does this put sand in the gears of clang support? Warner On May 27, 2011, at 5:51 AM, Alexander Best wrote: > hi there, >=20 > i would like to hear people's opinion regarding the following patch. = it > features the following semantic changes: >=20 > 1) -W is now called -Wextra > 2) move -fformat-extensions and -fdiagnostics-show-option out of = CWARNFLAGS, > since they aren't really warnings. this will now let anybody use = custom > CWARNFLAGS without having to remember to add -fformat-extensions in = order > not to break buildworld. > 3) rearrange "\" characters, as to avoid double spaces > 4) when building kernel modules, -fstack-protector was added to CFLAGS = twice. > this should now be solved. >=20 > cheers. > alex >=20 > --=20 > a13x > = _______________________________________________ > freebsd-toolchain@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to = "freebsd-toolchain-unsubscribe@freebsd.org"