From owner-svn-ports-all@FreeBSD.ORG  Fri Jan 17 18:54:51 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 374147BE; Fri, 17 Jan 2014 18:54:51 +0000 (UTC)
Date: Fri, 17 Jan 2014 18:54:51 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Martin Wilke <miwi@FreeBSD.org>
Subject: Re: svn commit: r340073 - head/graphics/gphoto2
Message-ID: <20140117185451.GA64598@FreeBSD.org>
References: <201401171656.s0HGuFpw077232@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201401171656.s0HGuFpw077232@svn.freebsd.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 18:54:51 -0000

On Fri, Jan 17, 2014 at 04:56:15PM +0000, Martin Wilke wrote:
> New Revision: 340073
> URL: http://svnweb.freebsd.org/changeset/ports/340073
> QAT: https://qat.redports.org/buildarchive/r340073/

(The following goes more to Kato and their ports sweatshop rather than
to Martin; just picking one commit of many.)

> -USES=		gmake pkgconfig
>  USE_BZIP2=	yes
> +USES=		gmake pkgconfig

This change is 1) gratuitous; 2) goes against most common practice of
placing USES above other USE_* knobs; 3) destroys my work of r322593.

> +post-patch:
> +	@${REINPLACE_CMD} -e \
> +		's|-lpthread|-pthread|' \
> +		${WRKSRC}/configure

This REINPLACE_CMD statement perfectly fits one 80-char line, why break
it up?

>  post-install:
> -	${INSTALL_DATA} ${WRKSRC}/NEWS ${STAGEDIR}${DOCSDIR}
> +	(cd ${WRKSRC} && ${INSTALL_DATA} NEWS ${STAGEDIR}${DOCSDIR})

Gratuitous; two commands instead of one; longer and less readable.  Why?

./danfe