From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Sep 9 15:30:12 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 48AF9106566C for ; Sun, 9 Sep 2012 15:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 344CA8FC0A for ; Sun, 9 Sep 2012 15:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q89FUCoe029603 for ; Sun, 9 Sep 2012 15:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q89FUCCZ029588; Sun, 9 Sep 2012 15:30:12 GMT (envelope-from gnats) Date: Sun, 9 Sep 2012 15:30:12 GMT Message-Id: <201209091530.q89FUCCZ029588@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Chris Rees Cc: Subject: Re: ports/171509: X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Sep 2012 15:30:12 -0000 The following reply was made to PR ports/171509; it has been noted by GNATS. From: Chris Rees To: Olli Hauer Cc: FreeBSD-gnats-submit@freebsd.org, Baptiste Daroussin Subject: Re: ports/171509: Date: Sun, 9 Sep 2012 16:21:45 +0100 --0015175dd6f0220ae304c94666f2 Content-Type: text/plain; charset=ISO-8859-1 Instead of patching bsd.options.mk, you could simply put the .if ... BROKEN stanza in apache/Makefile before the .include ; WITH variables are only defined after that unless in make.conf. .for o in ${OPTIONS_DEFINE} . if defined(WITH_$o) || defined(WITHOUT_$o) BROKEN=BLAH . endif .endfor I suggest this because I see it as an unusual situation. Have I been clear enough, or should I provide a patch? Chris --0015175dd6f0220ae304c94666f2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

Instead of patching bsd.op= tions.mk, you could simply put the .if ... BROKEN stanza in apache/Make= file before the .include <bsd.por= t.options.mk>; WITH variables are only defined after that unless in = make.conf.

.for o in ${OPTIONS_DEFINE}
. if defined(WITH_$o) || defined(WITHOUT_$o)
BROKEN=3DBLAH
. endif
.endfor

I suggest this because I see it as an unusual situation.

Have I been clear enough, or should I provide a patch?

Chris

--0015175dd6f0220ae304c94666f2--