From owner-freebsd-ports@FreeBSD.ORG Wed Mar 11 09:55:14 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1BC8E1065673 for ; Wed, 11 Mar 2009 09:55:14 +0000 (UTC) (envelope-from jadawin@tuxaco.net) Received: from huppa.tuxaco.net (unknown [IPv6:2001:41d0:1:66c1::1]) by mx1.freebsd.org (Postfix) with ESMTP id ACD508FC17 for ; Wed, 11 Mar 2009 09:55:13 +0000 (UTC) (envelope-from jadawin@tuxaco.net) Received: from localhost (unknown [127.0.0.1]) by huppa.tuxaco.net (Postfix) with ESMTP id 4E0FD228BB; Wed, 11 Mar 2009 10:57:38 +0100 (CET) X-Virus-Scanned: amavisd-new at tuxaco.net Received: from huppa.tuxaco.net ([127.0.0.1]) by localhost (huppa.tuxaco.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pqYT6HAxYag8; Wed, 11 Mar 2009 10:57:32 +0100 (CET) Received: from localhost (ilove.tuxaco.net [82.236.143.160]) (Authenticated sender: jadawin@tuxaco.net) by huppa.tuxaco.net (Postfix) with ESMTPA id 8DC0F228B6; Wed, 11 Mar 2009 10:57:32 +0100 (CET) Date: Wed, 11 Mar 2009 10:54:33 +0100 From: Philippe =?iso-8859-1?Q?Aud=E9oud?= To: Andriy Gapon Message-ID: <20090311095433.GB55246@tuxaco.net> References: <49B6A827.50705@icyb.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <49B6A827.50705@icyb.net.ua> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-ports@FreeBSD.ORG Subject: Re: request for a new port review [memtest86+] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 09:55:14 -0000 On Tue, 10 Mar 2009, Andriy Gapon wrote: >=20 > Guys, >=20 > could you please review the below port for correctness, style and general= approach > taken by me. > This is a port of memtest86+. Unlike existing sysutils/memtest86 this por= t is not > a download/extraction/version-tracking aid, rather it is designed to buil= d a > stand-alone ELF image (bootable by boot2 or loader) and/or an ISO image f= rom sources. > The first option does not need any additional justification, I think. The= second > option can be useful if you want to add some local patches on top of vend= or sources. >=20 > I am very grateful for the idea for this port and many technical details = of it to > Stephan Eisvogel. I also thank Eygene Ryabinkin for teaching me some thin= gs about ld. >=20 > Alternatives for /boot/opt are welcome :) >=20 > P.S. Stephan, I plan to create a distinct port for your version very soon. > I am also considering making it a port option for this proposed port, the= option > that would apply an extra patch. [...] Hello, Could you provide this shar in attachement please ? Thanks, --=20 Philippe Aud=E9oud -=3D- FreeBSD: The Power to Serve! -=3D-