Date: Thu, 07 Nov 2019 17:06:46 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r516900 - in head/multimedia: ffms2 vapoursynth vapoursynth-l-smash-works Message-ID: <tv7f-1xih-wny@FreeBSD.org> In-Reply-To: <20191107140053.d36yftvnvxceyhps@ogg.in.absolight.net> (Mathieu Arnold's message of "Thu, 7 Nov 2019 15:00:53 %2B0100") References: <201911061642.xA6GgS3V041740@repo.freebsd.org> <20191107081032.kqotphm5wzk3bhgf@atuin.in.mat.cc> <zhh7-gbfu-wny@FreeBSD.org> <20191107140053.d36yftvnvxceyhps@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@FreeBSD.org> writes: > On Thu, Nov 07, 2019 at 12:42:13PM +0100, Jan Beich wrote: > >> Mathieu Arnold <mat@FreeBSD.org> writes: >> >> > On Wed, Nov 06, 2019 at 04:42:28PM +0000, Jan Beich wrote: >> > >> >> Author: jbeich >> >> Date: Wed Nov 6 16:42:28 2019 >> >> New Revision: 516900 >> >> URL: https://svnweb.freebsd.org/changeset/ports/516900 >> >> >> >> Log: >> >> multimedia/vapoursynth: mark BROKEN on non-x86 >> >> >> >> Modified: >> >> head/multimedia/ffms2/Makefile (contents, props changed) >> >> head/multimedia/vapoursynth-l-smash-works/Makefile (contents, props changed) >> >> head/multimedia/vapoursynth/Makefile (contents, props changed) >> >> >> >> Modified: head/multimedia/ffms2/Makefile >> >> ============================================================================== >> >> --- head/multimedia/ffms2/Makefile Wed Nov 6 16:42:19 2019 (r516899) >> >> +++ head/multimedia/ffms2/Makefile Wed Nov 6 16:42:28 2019 (r516900) >> >> @@ -11,18 +11,24 @@ COMMENT= FFmpeg-based source library and VapourSynth p >> >> LICENSE= MIT >> >> LICENSE_FILE= ${WRKSRC}/COPYING >> >> >> >> +.if ${MACHINE_ARCH} == amd64 || ${MACHINE_ARCH} == i386 >> > >> > We never use MACHINE_ARCH in the ports tree, we use ARCH, and it is only >> > available after an include. All our tools use/set ARCH, so, please use >> > it. >> >> This is a temporary workaround, so avoiding "svn blame" churn is preferred. >> Also, I planned to switch ARCH to use MACHINE_ARCH internally in bug 215401. > > Whatever the reason, MACHINE_ARCH must never be used for tests, please > fix it to use ARCH. Can you provide a non-cargo-cult rationale? A number of ports (ignoring those in question) already use MACHINE_ARCH. Projects utilizing BSD make use MACHINE_ARCH because ARCH isn't available outside of the ports tree. ARCH appeared when make(1) already had MACHINE and MACHINE_ARCH. PkgSrc removed the cruft long ago. Why FreeBSD Ports insist on using a variable that have to be cached manually? https://svnweb.freebsd.org/changeset/ports/7262 https://svnweb.freebsd.org/changeset/csrg/40475 https://svnweb.freebsd.org/changeset/csrg/66396 https://github.com/NetBSD/pkgsrc/commit/5c4f3cc10810 # deperecation https://github.com/NetBSD/pkgsrc/commit/5cb86d057d46 # removal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?tv7f-1xih-wny>