Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Apr 2020 16:55:38 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 237290] [PATCH] build(7): PORTS_MODULES does not build in parallel
Message-ID:  <bug-237290-227-dOKau36m3W@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-237290-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-237290-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237290

--- Comment #8 from Bryan Drewery <bdrewery@FreeBSD.org> ---
(In reply to rozhuk.im from comment #3)

What's a terrible idea is making a change you don't understand. The -j flag
has 0 impact on the ports build except to BREAK it. -j is not how ports
are allowed to use make jobs. These fields are:

# MAKE_JOBS_UNSAFE
#               - Disallow multiple jobs even when user set a global overri=
de.
#                 To be used with known bad ports.
# DISABLE_MAKE_JOBS
#               - Set to disable the multiple jobs feature.  User settable.
# MAKE_JOBS_NUMBER
#               - Override the number of make jobs to be used.  User settab=
le.
# MAKE_JOBS_NUMBER_LIMIT
#               - Set a limit for maximum number of make jobs allowed to be
#                 used.


77      # Read ports defaults.
78      PORTSDIR?=3D      $(${MAKE} -V PORTSDIR)
79      DISTDIR?=3D       $(${MAKE} -V DISTDIR)
80      PORT_DBDIR?=3D    $(${MAKE} -V PORT_DBDIR)
81      OPTIONS_SET?=3D   $(${MAKE} -V OPTIONS_SET)
82      OPTIONS_UNSET?=3D $(${MAKE} -V OPTIONS_UNSET)
83      NO_CCACHE?=3D     $(${MAKE} -V NO_CCACHE)
84      CCACHE_DIR?=3D    $(${MAKE} -V CCACHE_DIR)
85      WITH_CCACHE_BUILD?=3D     $(${MAKE} -V WITH_CCACHE_BUILD)
86      DEFAULT_VERSIONS?=3D      $(${MAKE} -V DEFAULT_VERSIONS)
87      WITH_DEBUG_PORTS?=3D      $(${MAKE} -V WITH_DEBUG_PORTS)

This is completely redundant and not needed.

This is no such thing as maintainer timeout on this code as it is not ports.

I suggest if you want this fixed you explore why the MAKE_JOBS settings are=
 not
used and why those env vars were needed when they are already available in
ports.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-237290-227-dOKau36m3W>