From owner-freebsd-usb@freebsd.org Mon Jan 20 00:46:42 2020 Return-Path: Delivered-To: freebsd-usb@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 05250228FE0 for ; Mon, 20 Jan 2020 00:46:42 +0000 (UTC) (envelope-from Shichun.Ma@dell.com) Received: from mx0b-00154904.pphosted.com (mx0b-00154904.pphosted.com [148.163.137.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 481CfS2V1Yz3QD0 for ; Mon, 20 Jan 2020 00:46:39 +0000 (UTC) (envelope-from Shichun.Ma@dell.com) Received: from pps.filterd (m0170396.ppops.net [127.0.0.1]) by mx0b-00154904.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00K0jEAf016903 for ; Sun, 19 Jan 2020 19:46:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=smtpout1; bh=lSQPRKHJAp8VZShdL+vY/nicIc0/GsKhgz6y3KY2UNw=; b=MxrkybOh2saLqwM5tI5l608xnQ6FyPXwuhbrTySXRxDWdgdRF3W+jhagQ5QjNbTO0RKl 31gv0IsW0WpRX1YKFty8A9KbwEDOgtq6bgy4aVE+hXgwzHFl/ykoCAG/wAcadYfLHenm X+0Ly0zs17IDFnSOWmtsjVkCS15XJlF1+RvF9bHmpgh/GUy6x2rDa6MSflzdGpx7EHNk Lg7VNI3Fu6rrCRMpAZBlDK9u7Kle/dEgAkKQl68puKbdy9p/igPc8QSqPTqFgbRsgBPY L1WyO1+tZWDA6gEvhde3DrKvAtGuxDbqCU1EZ8AUl/oD3gC6XGKn46SbeZaGWlV++7fk 0w== Received: from mx0b-00154901.pphosted.com (mx0b-00154901.pphosted.com [67.231.157.37]) by mx0b-00154904.pphosted.com with ESMTP id 2xkxr2c4sj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 19 Jan 2020 19:46:39 -0500 Received: from pps.filterd (m0089483.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00K0hCNu009473 for ; Sun, 19 Jan 2020 19:46:38 -0500 Received: from ausxipps310.us.dell.com (AUSXIPPS310.us.dell.com [143.166.148.211]) by mx0b-00154901.pphosted.com with ESMTP id 2xmwvw9x7x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 19 Jan 2020 19:46:38 -0500 X-LoopCount0: from 10.166.136.213 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,349,1549951200"; d="scan'208";a="473769047" From: To: , CC: Subject: Re: USB keyboard/mouse wake up from S3 Thread-Topic: USB keyboard/mouse wake up from S3 Thread-Index: AQHVx199ZSq7SdYbTEa/gzYTMChF7qfjE32AgACMne3//382AIALHIZ+///j8gCAAEd9AIAEXOPo Date: Mon, 20 Jan 2020 00:46:34 +0000 Message-ID: <1579481192594.378@Dell.com> References: <1578625588784.46788@Dell.com> <47257477-bace-a9c5-69f5-7a0eb7af3947@selasky.org> <1578648297338.92657@Dell.com> <685f991f-6cb6-3f27-65d8-38181e4cfa8e@selasky.org> <1579231397567.62223@Dell.com> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.242.75] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-19_08:2020-01-16, 2020-01-19 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=559 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001200003 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 mlxlogscore=702 priorityscore=1501 phishscore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001200003 X-Rspamd-Queue-Id: 481CfS2V1Yz3QD0 X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=dell.com header.s=smtpout1 header.b=MxrkybOh; dmarc=pass (policy=none) header.from=dell.com; spf=pass (mx1.freebsd.org: domain of Shichun.Ma@dell.com designates 148.163.137.20 as permitted sender) smtp.mailfrom=Shichun.Ma@dell.com X-Spamd-Result: default: False [-7.59 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[dell.com:s=smtpout1]; HAS_XOIP(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_FIVE(0.00)[5]; R_SPF_ALLOW(-0.20)[+ip4:148.163.137.20]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-usb@freebsd.org]; TO_DN_NONE(0.00)[]; DWL_DNSWL_LOW(-1.00)[dell.com.dwl.dnswl.org : 127.0.9.1]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[dell.com:+]; DMARC_POLICY_ALLOW(-0.50)[dell.com,none]; FROM_NO_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[20.137.163.148.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:22843, ipnet:148.163.137.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.49)[ip: (-0.20), ipnet: 148.163.137.0/24(-0.09), asn: 22843(-2.10), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[dell.com:d:+,dell.com:s:+] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jan 2020 00:46:42 -0000 Hi HPS,=0A= Sorry, but I just have Intel SOC which only has XHCI integrated, =0A= I just tested with Intel's Gemini Lake SOC, and I can further test it with= DELL OptiPlex later.=0A= I agree with your idea that preserves old behavior by default.=0A= =0A= Thanks & Regards,=0A= =0A= Shichun Ma=0A= Software Engineer=0A= Dell | Cloud Client Computing=0A= office +86 10 82862579, Mobile +86 13241851528=0A= shichun_ma@dell.com=0A= =0A= =0A= =0A= ________________________________________=0A= From: Hans Petter Selasky =0A= Sent: Friday, January 17, 2020 9:57 PM=0A= To: Ma, Horse; freebsd-usb@freebsd.org=0A= Cc: Jason_YH_Yang@wistron.com=0A= Subject: Re: USB keyboard/mouse wake up from S3=0A= =0A= [EXTERNAL EMAIL]=0A= =0A= On 2020-01-17 10:41, Hans Petter Selasky wrote:=0A= > On 2020-01-17 04:23, Shichun.Ma@dell.com wrote:=0A= >>=0A= >> HPS,=0A= >>=0A= >> Here is my patch to enable USB wakeup under XHCI, I tested USB=0A= >> mouse/keyboard can wake up system from S3.=0A= >>=0A= >=0A= > Hi,=0A= >=0A= > Patches look OK, with some minor nits.=0A= >=0A= > Have you thought about adding EHCI/OHCI/UHCI to the wakeup matrix aswell?= =0A= >=0A= > How many different computers and CPU architectures has this code been=0A= > tested with?=0A= >=0A= =0A= Also I want you to add a sysctl, hw.usb.no_wakeup, which if set,=0A= preserves the old behaviour.=0A= =0A= Thank you!=0A= =0A= --HPS=0A= =0A=