From owner-freebsd-hackers Tue Oct 2 15:58: 6 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from elvis.mu.org (elvis.mu.org [216.33.66.196]) by hub.freebsd.org (Postfix) with ESMTP id EA53737B405 for ; Tue, 2 Oct 2001 15:58:03 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id D80B981D01; Tue, 2 Oct 2001 17:57:58 -0500 (CDT) Date: Tue, 2 Oct 2001 17:57:58 -0500 From: Alfred Perlstein To: Peter Pentchev , freebsd-hackers@FreeBSD.org Subject: Re: Doubt of system(3) Message-ID: <20011002175758.M59854@elvis.mu.org> References: <200109291527.f8TFRrU76727.toshi@jp.FreeBSD.org> <20010929153433.U59854@elvis.mu.org> <20010929214338.A57903@gattaca.yadt.co.uk> <20010929221658.B57903@gattaca.yadt.co.uk> <20010929170332.Y59854@elvis.mu.org> <20010929232839.A91153@gattaca.yadt.co.uk> <20011002130942.C704@ringworld.oblivion.bg> <20011002112707.C59854@elvis.mu.org> <20011002220152.A3056@gattaca.yadt.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011002220152.A3056@gattaca.yadt.co.uk>; from davidt@yadt.co.uk on Tue, Oct 02, 2001 at 10:01:52PM +0100 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * David Taylor [011002 16:02] wrote: > On Tue, 02 Oct 2001, Alfred Perlstein wrote: > > * Peter Pentchev [011002 05:21] wrote: > > > On Sat, Sep 29, 2001 at 11:28:39PM +0100, David Taylor wrote: > > > [snip] > > > > IMO, the below patch is probably the best solution. > > > > > > Yep, it also fixes the fact that the return value from wait4() needs > > > to be preserved, at least for the return statement of __system(). > > > > Aaaaaaaaaaah! Forgot about it, I'm going to upgrade my workstation > > now and commit it if it works, probably tonight. > > > > If someone else can test it earlier, by all means commit it. > > Just to say that as I did a make world today, I took the opportunity to test > the patch, and it does fix the bug. Thanks for taking the time to do this and thanks for the feedback. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message