From owner-cvs-src@FreeBSD.ORG Tue Apr 10 16:47:19 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C937616A402; Tue, 10 Apr 2007 16:47:19 +0000 (UTC) (envelope-from brian@Awfulhak.org) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.freebsd.org (Postfix) with ESMTP id 61ACF13C48C; Tue, 10 Apr 2007 16:47:19 +0000 (UTC) (envelope-from brian@Awfulhak.org) Received: from store.lan.Awfulhak.org (store.lan.Awfulhak.org [172.16.0.35]) by storm.uk.FreeBSD.org (8.13.8/8.13.8) with ESMTP id l3AGlE3k019267; Tue, 10 Apr 2007 17:47:14 +0100 (BST) (envelope-from brian@Awfulhak.org) Received: from store.lan.Awfulhak.org (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id 9D6771957C90; Tue, 10 Apr 2007 16:47:20 +0000 (GMT) Received: from gw.Awfulhak.org (gw.lan.Awfulhak.org [172.16.0.1]) by store.lan.Awfulhak.org (Postfix) with ESMTP id 7DCCF1957C83; Tue, 10 Apr 2007 16:47:12 +0000 (GMT) Received: from conflict.ca.sophos.com (brian@localhost [127.0.0.1]) by gw.Awfulhak.org (8.13.8/8.13.8) with ESMTP id l3AGl0I2011084; Tue, 10 Apr 2007 09:47:00 -0700 (PDT) (envelope-from brian@Awfulhak.org) Date: Tue, 10 Apr 2007 09:46:59 -0700 From: Brian Somers To: "Greg 'groggy' Lehey" Message-ID: <20070410094659.49041afb@conflict.ca.sophos.com> In-Reply-To: <20070410071256.GJ91694@wantadilla.lemis.com> References: <200704090219.l392Jc1f064727@repoman.freebsd.org> <864pnpdf8w.fsf@dwp.des.no> <20070410010901.GD61460@wantadilla.lemis.com> <86zm5gr9wl.fsf@dwp.des.no> <20070410071256.GJ91694@wantadilla.lemis.com> X-Mailer: Claws Mail 2.8.1 (GTK+ 2.10.11; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED,SPF_HELO_PASS, SPF_PASS autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on gw.lan.Awfulhak.org Cc: Dag-Erling =?UTF-8?B?U23DuHJncmF2?= , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/touch touch.1 touch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2007 16:47:19 -0000 On Tue, 10 Apr 2007 16:42:56 +0930 "Greg 'groggy' Lehey" wrote: > On Tuesday, 10 April 2007 at 9:00:42 +0200, Dag-Erling Smrgrav wrote: > > Greg 'groggy' Lehey writes: > >> On Monday, 9 April 2007 at 12:16:47 +0200, Dag-Erling Smrgrav wrote: > >>> The latter part is incorrect and should be reverted. Furthermore, > >>> usage() should be static. > >> Can you give details? > > > > usage() should be the way it was before your commit, except that it > > should be static. > > You mean declared as a static function? In a program of a single > file? > > As I said before, > > >> Can you give details? > > Specifically, this doesn't match my recollection of "good practice". > Where is this behaviour mandated? Bump WARNS? Every function should be either prototyped or declared static (or both). -- Brian Somers Don't _EVER_ lose your sense of humour !