From owner-cvs-sys Mon Jun 2 05:08:10 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id FAA15700 for cvs-sys-outgoing; Mon, 2 Jun 1997 05:08:10 -0700 (PDT) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA15694; Mon, 2 Jun 1997 05:08:04 -0700 (PDT) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.8.5/8.8.5) with SMTP id NAA00348; Mon, 2 Jun 1997 13:08:04 +0100 (BST) Date: Mon, 2 Jun 1997 13:08:04 +0100 (BST) From: Doug Rabson To: Michael Smith cc: Doug Rabson , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/linux linux_ioctl.c In-Reply-To: <199706021156.VAA22869@genesis.atrad.adelaide.edu.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Mon, 2 Jun 1997, Michael Smith wrote: > Doug Rabson stands accused of saying: > > dfr 1997/06/02 03:43:42 PDT > > > > Modified files: > > sys/i386/linux linux_ioctl.c > > Log: > > Make this thing actually compile. > > It _ought_ to have compiled before. It would appear, however, that in > the context of ether_ifattach (which is where I picked the logic from > for 2.2), it is still wrong; it should probably just walk ifnet_addrs > looking for the first AL_LINK/IFT_ETHER address, but I did the code in > a hurry. > > If you think the above approach (walking ifnet_addrs) is better, I'll > send you a change for verification before committing the *&^%*&^% > thing 8) I don't know what the right approach is; all I know is that ifp->if_addrlist doesn't exist on 3.0. I assumed that it was replaced by ifp->if_addrhead, which is a TAILQ. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039