From owner-freebsd-ports@freebsd.org  Thu Oct 27 06:21:38 2016
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25293C22D28
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Thu, 27 Oct 2016 06:21:38 +0000 (UTC)
 (envelope-from c.brinkhaus@t-online.de)
Received: from mailout09.t-online.de (mailout09.t-online.de [194.25.134.84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mailout00.t-online.de",
 Issuer "TeleSec ServerPass DE-2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D842CBEA
 for <freebsd-ports@freebsd.org>; Thu, 27 Oct 2016 06:21:37 +0000 (UTC)
 (envelope-from c.brinkhaus@t-online.de)
Received: from fwd35.aul.t-online.de (fwd35.aul.t-online.de [172.20.27.145])
 by mailout09.t-online.de (Postfix) with SMTP id 921174273A5F;
 Thu, 27 Oct 2016 08:21:34 +0200 (CEST)
Received: from esprimo.local
 (Ekq4hBZfrh0lLNYBHG2z58U7t7tJwstpQkB3OCH1d87KRkeNYH56VJgBB3rMR6vgzR@[217.81.159.182])
 by fwd35.t-online.de
 with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted)
 esmtp id 1bze4A-2vaKMi0; Thu, 27 Oct 2016 08:21:30 +0200
Received: from esprimo.local (localhost [127.0.0.1])
 by esprimo.local (Postfix) with ESMTP id 0D92F45CD8A;
 Thu, 27 Oct 2016 08:21:29 +0200 (CEST)
Received: (from chris@localhost)
 by esprimo.local (8.15.2/8.15.2/Submit) id u9R6LTVS008811;
 Thu, 27 Oct 2016 08:21:29 +0200 (CEST) (envelope-from chris)
Date: Thu, 27 Oct 2016 08:21:29 +0200
From: Christoph Brinkhaus <c.brinkhaus@t-online.de>
To: Jochen Neumeister <joneum@bsdproject.de>
Cc: "freebsd-ports@freebsd.org" <freebsd-ports@freebsd.org>
Subject: Re: make makepatch
Message-ID: <20161027062129.GA2491@esprimo.local>
References: <730bd5a8-d6c2-7e8f-5240-b7d4b6209884@bsdproject.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <730bd5a8-d6c2-7e8f-5240-b7d4b6209884@bsdproject.de>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-ID: Ekq4hBZfrh0lLNYBHG2z58U7t7tJwstpQkB3OCH1d87KRkeNYH56VJgBB3rMR6vgzR
X-TOI-MSGID: 68189b33-e483-4fb6-8202-e4e7641e4f3b
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Oct 2016 06:21:38 -0000

On Thu, Oct 27, 2016 at 07:47:06AM +0200, Jochen Neumeister wrote:

Hello Jochen!

> I will update the net/wpa_gui.
> 
> # portlint
> WARN: /usr/home/joneum/dev/ports/net/wpa_gui/files/patch-wpa_ctrl.c:
> patch was not generated using ``make makepatch''.  It is recommended to
> use ``make makepatch'' when you need to [re-]generate a patch to ensure
> proper patch format.
> 0 fatal errors and 1 warning found.

The proper way should be to restore the original file wpa_ctrl.c
as wps.ctrl.orig. Then "make makepatch" has something to compare
and should generate the patch file.
> 
> okay, i use "make makepatch", and copy the files from
> "work/.makepatch-tmp/archived-patches" to the "/files" folder, and start
> portlint. But, the same.

For verification if everything is fine you should clean up
everything by "make clean". The port should be now as
original, but with your additional patch file.
Now portlint should accept the patch.

I hope I mentioned everything.

Kind regards,
Christoph