From owner-cvs-all@FreeBSD.ORG Sun Apr 27 05:50:50 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0527F37B401; Sun, 27 Apr 2003 05:50:50 -0700 (PDT) Received: from mailhub.fokus.fraunhofer.de (mailhub.fokus.fraunhofer.de [193.174.154.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 66B5243F3F; Sun, 27 Apr 2003 05:50:47 -0700 (PDT) (envelope-from brandt@fokus.fraunhofer.de) Received: from beagle (beagle [193.175.132.100])h3RCokE02356; Sun, 27 Apr 2003 14:50:46 +0200 (MEST) Date: Sun, 27 Apr 2003 14:50:46 +0200 (CEST) From: Harti Brandt To: "David O'Brien" In-Reply-To: <20030426160225.GA8241@dragon.nuxi.com> Message-ID: <20030427144646.G61593@beagle.fokus.fraunhofer.de> References: <200304251614.h3PGE3t5006537@repoman.freebsd.org> <20030426160225.GA8241@dragon.nuxi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Hartmut Brandt cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile src/sys/pci if_en_pci.c midwayvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Apr 2003 12:50:50 -0000 On Sat, 26 Apr 2003, David O'Brien wrote: DO>On Fri, Apr 25, 2003 at 09:14:03AM -0700, Hartmut Brandt wrote: DO>> Modified files: DO>> sys/modules Makefile DO>> sys/pci if_en_pci.c DO>> sys/dev/en midway.c midwayreg.h midwayvar.h DO>> Added files: DO>> sys/modules/en Makefile DO>> Log: DO>> Convert the midway driver to use busdma. Except for this conversion the DO>> following changes have been done: DO>> DO>> - stylify. The original code was too hard to read. DO>> - get rid of a number of compilation options (Adaptec-only, Eni-only, no-DMA). DO>> - more debugging features. DO>> - locking. This is not correct yet in the absence of interface layer locking, DO> DO>Were you not aware we have rules against exactly this type of commit?? DO>It is totally impossible to tell what the real changes were and which the DO>style changes were. Please don't make a commits like this again. All this stuff was ready before I got my commit bit. At that time I did not care. After that, given that actually only a handful people care about this driver, I thought that it makes not much sense to do the work twice and factor out the style changes from the patch. I don't have another patch of this kind, so don't be afraid... harti -- harti brandt, http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org