From owner-svn-ports-all@FreeBSD.ORG  Sun Feb  9 13:37:59 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 5C808107;
 Sun,  9 Feb 2014 13:37:59 +0000 (UTC)
Received: from mx.critical.ch (mx.critical.ch [IPv6:2001:1620:f05::1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C4973168B;
 Sun,  9 Feb 2014 13:37:58 +0000 (UTC)
Received: from beaver.home.critical.ch (77-59-132-3.dclient.hispeed.ch
 [77.59.132.3]) (authenticated bits=0)
 by mx.critical.ch (8.14.7/8.14.7/critical-1.0) with ESMTP id s19Dbucf072850;
 Sun, 9 Feb 2014 14:37:56 +0100 (CET)
 (envelope-from ehaupt@FreeBSD.org)
Date: Sun, 9 Feb 2014 14:37:56 +0100
From: Emanuel Haupt <ehaupt@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r343457 - head/audio/p5-Shout
Message-Id: <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org>
In-Reply-To: <D51FCA4F34828A264C471DCA@atuin.in.mat.cc>
References: <201402091101.s19B1aPh072112@svn.freebsd.org>
 <1E1640591FF296C66F82EF62@atuin.in.mat.cc>
 <20140209131626.ad5097b391ebb1e6d738e28a@FreeBSD.org>
 <D51FCA4F34828A264C471DCA@atuin.in.mat.cc>
X-Mailer: Sylpheed 3.3.0 (GTK+ 2.24.22; amd64-portbld-freebsd10.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Feb 2014 13:37:59 -0000

Mathieu Arnold <mat@FreeBSD.org> wrote:
> +--On 9 f=E9vrier 2014 13:16:26 +0100 Emanuel Haupt <ehaupt@FreeBSD.org>
> wrote:
> | Mathieu Arnold <mat@FreeBSD.org> wrote:
> |>=20
> |>=20
> |> +--On 9 f=E9vrier 2014 11:01:36 +0000 Emanuel Haupt
> |> <ehaupt@FreeBSD.org> wrote:
> |> | +.include <bsd.port.options.mk>
> |> | +
> |> |  post-install:
> |> | -.ifndef(NOPORTDOCS)
> |> | -	@${MKDIR} ${DOCSDIR}
> |> | -	${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${DOCSDIR}
> |> | -.endif
> |> | +	${STRIP_CMD} ${STAGEDIR}
> |> | ${SITE_PERL}/${PERL_ARCH}/auto/Shout/Shout.so
> |> | +	${MKDIR} ${STAGEDIR}${DOCSDIR}
> |> | +	${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${STAGEDIR}
> |> | ${DOCSDIR}=20
> |> |  .include <bsd.port.mk>
> |>=20
> |> What do you need bsd.port.options.mk for ?
> |=20
> | I think it's required for dealing with the conditional installation
> | of:
> |=20
> |         ${MKDIR} ${STAGEDIR}${DOCSDIR}
> |         ${INSTALL_SCRIPT} ${WRKSRC}/example*.pl ${STAGEDIR}
> | ${DOCSDIR}
>=20
> Yes, and like the wiki[1] says, unless there's a tremendous number of
> files and the IO hit is pretty severe you should install them always.

So you agree with me that the inclusion is required?

> (Also, if those are examples, they should go in EXAMPLESDIR)

I was simply looking at the aspect of converting the port to support
staging. I don't know if the application requires the files to be
installed in EXAMPLESDIR or DOCSDIR.

Emanuel