From owner-freebsd-acpi@FreeBSD.ORG Mon Apr 9 16:53:29 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52F46106566C; Mon, 9 Apr 2012 16:53:29 +0000 (UTC) (envelope-from nate@root.org) Received: from mail.rootlabs.com (rootlabs.com [208.72.84.106]) by mx1.freebsd.org (Postfix) with ESMTP id 27C248FC19; Mon, 9 Apr 2012 16:53:28 +0000 (UTC) Received: (Postfix invoked from local network); Mon, 9 Apr 2012 16:53:27 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=windows-1252 From: Nate Lawson In-Reply-To: Date: Mon, 9 Apr 2012 09:53:28 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <30133A83-88E4-4715-8514-E9229E9AF078@root.org> References: To: Robert Millan X-Mailer: Apple Mail (2.1084) Cc: freebsd-acpi@freebsd.org, Steven Chamberlain Subject: Re: [PATCH] Abort powerd when no cpufreq(4) support is found X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2012 16:53:29 -0000 On Apr 9, 2012, at 9:51 AM, Robert Millan wrote: > Hi Nate, >=20 > El 9 d=92abril de 2012 18:06, Nate Lawson ha escrit: >> The message is fine, but I think an error code of 0 is wrong. Powerd = didn't start, whereas 0 means the daemon launched successfully. >=20 > In that case, may I suggest that we return one of the error codes > recommended by sysexists(3)? EX_UNAVAILABLE seems close enough to the > reason we're aborting. Fine by me. The rc framework or user should be the one to interpret the = error code and realize that it's ok that it's not running (not = supported). -Nate=