From owner-freebsd-hackers@freebsd.org Fri Jan 5 23:17:39 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A9B6EA60BC for ; Fri, 5 Jan 2018 23:17:39 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f42.google.com (mail-it0-f42.google.com [209.85.214.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18BF164C12 for ; Fri, 5 Jan 2018 23:17:38 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f42.google.com with SMTP id b77so108422itd.0 for ; Fri, 05 Jan 2018 15:17:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=8pFJ10xLWQixEl5Bh26lwm5KQhdLH86d7NX5KGdZLeg=; b=Xj/qXUgRhfRv6Tt4SRCTrrR932WJk9DhTtjviQ7TBxYfgkOiheeufI2+FGK6MOORjk +PGPYw6EMw4ZOqDE/mMCfu/AxL/+8gLjLdABw3T9zjmPXAE2bbRF5I+qhwFU6JtHRPwE zvJji77fdwqK/2jPIFeQ2Ygxt/etrNF73GbXNBaLhsEy0d5icsSufGlLQG9Oymk9n8nM gZB7rXpgIfeWs/VDegJR2GUDq3kvAo0zmF+5fUD43nSvNpr2leinZnezQQ7cct3542J0 iSNc7+k2wrAcJzSFydJeS9x+dI4LdaJXpMUNUKDG+TuXGK0HB8edBA972KGCwwHaKyUZ dfew== X-Gm-Message-State: AKGB3mJiB0HXEe9KCK023s6u7DO0nDIcqOgJXx4YpOP8J+utJyVISfWx 0jMTqji/6c4/bDla4/fH+PCjZu/t X-Google-Smtp-Source: ACJfBosAOvU4gilJqNlm08xpcH/6xZSsENGriYpWsTcy60GUwdb80m9TLVvvUBER93gfJJoN1AOmvw== X-Received: by 10.36.250.202 with SMTP id v193mr4977041ith.114.1515194252614; Fri, 05 Jan 2018 15:17:32 -0800 (PST) Received: from mail-it0-f52.google.com (mail-it0-f52.google.com. [209.85.214.52]) by smtp.gmail.com with ESMTPSA id l28sm4133138iod.32.2018.01.05.15.17.32 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2018 15:17:32 -0800 (PST) Received: by mail-it0-f52.google.com with SMTP id f143so3398257itb.0 for ; Fri, 05 Jan 2018 15:17:32 -0800 (PST) X-Received: by 10.36.7.65 with SMTP id f62mr4900098itf.75.1515194252167; Fri, 05 Jan 2018 15:17:32 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.15.193 with HTTP; Fri, 5 Jan 2018 15:17:31 -0800 (PST) In-Reply-To: <24173.1515191675@critter.freebsd.dk> References: <24acbd94-c52f-e71a-8a96-d608a10963c6@rawbw.com> <1514572041.12000.7.camel@freebsd.org> <20180105221330.GD95035@spindle.one-eyed-alien.net> <24173.1515191675@critter.freebsd.dk> From: Conrad Meyer Date: Fri, 5 Jan 2018 15:17:31 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Is it considered to be ok to not check the return code of close(2) in base? To: Poul-Henning Kamp Cc: Freebsd hackers list Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 23:17:39 -0000 On Fri, Jan 5, 2018 at 2:34 PM, Poul-Henning Kamp wrote: > Brookes suggestion, while well intentioned, wouldn't get very far, > because it is common for shells and shell-like programs to do: > > for (i = 3; i < ALOT; i++) > (void)close(i); > > To get rid of unwanted filedescriptors from syslog(3), getpwent(3) etc. > in the child process. > > Yes, I know about closefrom(2), but a lot of programs still don't use it. Hi, That seems like a good way to quickly identify programs in base that still do not use closefrom(). Best, Conrad