From owner-freebsd-bugs  Sun Jul 19 11:51:29 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id LAA07908
          for freebsd-bugs-outgoing; Sun, 19 Jul 1998 11:51:29 -0700 (PDT)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA07900
          for <freebsd-bugs@FreeBSD.org>; Sun, 19 Jul 1998 11:51:28 -0700 (PDT)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.8.8/8.8.5) id LAA04250;
	Sun, 19 Jul 1998 11:50:02 -0700 (PDT)
Received: (from nobody@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id LAA07743;
          Sun, 19 Jul 1998 11:48:51 -0700 (PDT)
          (envelope-from nobody)
Message-Id: <199807191848.LAA07743@hub.freebsd.org>
Date: Sun, 19 Jul 1998 11:48:51 -0700 (PDT)
From: Anders.X.Thulin@telia.se
To: freebsd-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: www-1.0
Subject: bin/7319: routed/rtquery: bad pointer comparison
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         7319
>Category:       bin
>Synopsis:       routed/rtquery: bad pointer comparison
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 19 11:50:01 PDT 1998
>Last-Modified:
>Originator:     Anders Thulin
>Organization:
(none)
>Release:        2.2.6 (Walnut Creek CD)
>Environment:
FreeBSD myname.my.domain 2.2.6-RELEASE FreeBSD 2.2.6-RELEASE #0: Wed Mar 25 02:28:49 GMT 1998
     jkh@time.cdrom.com:/usr/src/sys/compile/GENERIC  i386
>Description:
/usr/src/sbin/routed/parms.c and .../routed/rtquery/rtquery.c both
contain code that compare a char pointer with a char.
  As this doesn't make much sense, it looks very much as if a '*'
has been dropped by mistake.
  I have made no analysis of the possible consequences of the problem.

>How-To-Repeat:
Not applicable -- I discovered the problem while linting the code.


>Fix:
.../routed/parms.c:
379c379
< 		if (c == '\\' && pc != '\0') {
---
> 		if (c == '\\' && *pc != '\0') {

.../routed/rtquery/rtquery.c:
809c809
< 		if (c == '\\' && pc != '\0') {
---
> 		if (c == '\\' && *pc != '\0') {

>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message