Date: Sun, 5 Jun 2016 19:57:53 +0000 (UTC) From: Thomas Zander <riggs@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org Subject: svn commit: r416424 - in branches/2016Q2/devel: gdb gdb/files gdb66/files Message-ID: <201606051957.u55JvrWT051920@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: riggs Date: Sun Jun 5 19:57:53 2016 New Revision: 416424 URL: https://svnweb.freebsd.org/changeset/ports/416424 Log: MFH: r416247 r416392 Make GDB build when basename() is POSIX compliant. GDB's libiberty.h has a prototype of the basename() function it which does not match the one that is part of POSIX, declared in libgen.h. This is normally never visible, as GDB never includes libgen.h. On FreeBSD, it unfortunately is, as our locally added copy of kgdb includes both. Fix up libiberty.h to just include libgen.h. I'm currently discussing with upstream how a clean fix should be done, but I guess that requires more refactoring to the existing code. We'd better not bother importing that and stick to this compact workaround. Reviewed by: bapt@, mi@, Luca Pizzamiglio Differential Revision: https://reviews.freebsd.org/D6630 Update to upstream release 7.11.1 Includes several runtime fixes, e.g. crashes on reverse-stepi and use-after-free errors, see https://www.gnu.org/software/gdb/news/ PR: 209935 Submitted by: luca.pizzamiglio@gmail.com (maintainer) Approved by: ports-secteam (junovitch) Added: branches/2016Q2/devel/gdb/files/patch-libiberty-basename - copied unchanged from r416247, head/devel/gdb/files/patch-libiberty-basename branches/2016Q2/devel/gdb66/files/patch-libiberty-basename - copied unchanged from r416247, head/devel/gdb66/files/patch-libiberty-basename Modified: branches/2016Q2/devel/gdb/Makefile branches/2016Q2/devel/gdb/distinfo Directory Properties: branches/2016Q2/ (props changed) Modified: branches/2016Q2/devel/gdb/Makefile ============================================================================== --- branches/2016Q2/devel/gdb/Makefile Sun Jun 5 19:49:04 2016 (r416423) +++ branches/2016Q2/devel/gdb/Makefile Sun Jun 5 19:57:53 2016 (r416424) @@ -2,8 +2,8 @@ # $FreeBSD$ PORTNAME= gdb -PORTVERSION= 7.11 -PORTREVISION= 2 +PORTVERSION= 7.11.1 +#PORTREVISION= 2 CATEGORIES= devel MASTER_SITES= GNU Modified: branches/2016Q2/devel/gdb/distinfo ============================================================================== --- branches/2016Q2/devel/gdb/distinfo Sun Jun 5 19:49:04 2016 (r416423) +++ branches/2016Q2/devel/gdb/distinfo Sun Jun 5 19:57:53 2016 (r416424) @@ -1,2 +1,3 @@ -SHA256 (gdb-7.11.tar.xz) = 7a434116cb630d77bb40776e8f5d3937bed11dea56bafebb4d2bc5dd389fe5c1 -SIZE (gdb-7.11.tar.xz) = 18934392 +TIMESTAMP = 1464770611 +SHA256 (gdb-7.11.1.tar.xz) = e9216da4e3755e9f414c1aa0026b626251dfc57ffe572a266e98da4f6988fc70 +SIZE (gdb-7.11.1.tar.xz) = 18947760 Copied: branches/2016Q2/devel/gdb/files/patch-libiberty-basename (from r416247, head/devel/gdb/files/patch-libiberty-basename) ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ branches/2016Q2/devel/gdb/files/patch-libiberty-basename Sun Jun 5 19:57:53 2016 (r416424, copy of r416247, head/devel/gdb/files/patch-libiberty-basename) @@ -0,0 +1,11 @@ +--- include/libiberty.h ++++ include/libiberty.h +@@ -109,7 +109,7 @@ + || defined (__FreeBSD__) || defined (__OpenBSD__) || defined (__NetBSD__) \ + || defined (__CYGWIN__) || defined (__CYGWIN32__) || defined (__MINGW32__) \ + || defined (__DragonFly__) || defined (HAVE_DECL_BASENAME) +-extern char *basename (const char *) ATTRIBUTE_RETURNS_NONNULL ATTRIBUTE_NONNULL(1); ++#include <libgen.h> + #else + /* Do not allow basename to be used if there is no prototype seen. We + either need to use the above prototype or have one from Copied: branches/2016Q2/devel/gdb66/files/patch-libiberty-basename (from r416247, head/devel/gdb66/files/patch-libiberty-basename) ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ branches/2016Q2/devel/gdb66/files/patch-libiberty-basename Sun Jun 5 19:57:53 2016 (r416424, copy of r416247, head/devel/gdb66/files/patch-libiberty-basename) @@ -0,0 +1,11 @@ +--- include/libiberty.h ++++ include/libiberty.h +@@ -98,7 +98,7 @@ + is 1, we found it so don't provide any declaration at all. */ + #if !HAVE_DECL_BASENAME + #if defined (__GNU_LIBRARY__ ) || defined (__linux__) || defined (__FreeBSD__) || defined (__OpenBSD__) || defined(__NetBSD__) || defined (__CYGWIN__) || defined (__CYGWIN32__) || defined (__MINGW32__) || defined (HAVE_DECL_BASENAME) +-extern char *basename (const char *); ++#include <libgen.h> + #else + /* Do not allow basename to be used if there is no prototype seen. We + either need to use the above prototype or have one from
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201606051957.u55JvrWT051920>