From owner-freebsd-fs@FreeBSD.ORG Mon May 9 15:44:55 2005 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9231316A4E8 for ; Mon, 9 May 2005 15:44:55 +0000 (GMT) Received: from blackwater.lemis.com (wantadilla.lemis.com [192.109.197.135]) by mx1.FreeBSD.org (Postfix) with ESMTP id 158DA43D75 for ; Mon, 9 May 2005 15:44:54 +0000 (GMT) (envelope-from grog@lemis.com) Received: from blackwater.lemis.com (wantadilla.lemis.com [192.109.197.135]) by blackwater.lemis.com (Postfix) with ESMTP id 916B9856AE; Tue, 10 May 2005 01:14:49 +0930 (CST) Received: by blackwater.lemis.com (Postfix, from userid 1004) id AFCDF4D2FF; Mon, 9 May 2005 10:43:38 -0500 (CDT) Date: Mon, 9 May 2005 10:43:38 -0500 From: Greg 'groggy' Lehey To: Jean-Sebastien Pedron Message-ID: <20050509154338.GD1592@eucla.lemis.com> References: <427F491C.4090501@club-internet.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <427F491C.4090501@club-internet.fr> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: freebsd-fs@freebsd.org Subject: Re: Call for feedback about ReiserFS import X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2005 15:44:55 -0000 On Monday, 9 May 2005 at 13:27:24 +0200, Jean-Sbastien Pdron wrote: > Hi everyone, > > The current port of ReiserFS is ready to be imported in the tree for a > few months, however my mentor mux@ and I have concerns about the > organization of the sources of this version. > > Originally, the port is based on Linux 2.6.7. My goal was to distribute > it as a 3rd party package, maybe a port. Because I was interested in > kernel development and how ReiserFS was working, I started from scratch, > bringing the necessary pieces of code from Linux little by little, to > achieve read-only support. > > The main issue with this approach is maintainability: the filenames and > source layout is different between the original Linux version and the > port. Changes in the Linux tree are harder to track. > > I'd like to import this version in FreeBSD's tree, because: > - ReiserFS' homepage (http://www.namesys.com/) says it shouldn't evolve > anymore (just rare bugfixes). For instance, between Linux 2.6.7 and > 2.6.11.3, they added a few checks of functions' return code. > - with my approach, I have a better knowledge of the filesystem > internals. If we want a BSD licensed version, it should be easier. > - work is more interesting this way than just make the Linux version > compile. This may be true, but it isn't really relevant to what goes into the tree. > - it's already done ;) Well, as far as it goes. I wouldn't say it's done until you have the complete functionality. > But I know that the tradition is to import external code with changes as > less intrusive as possible, for good reason. Does anyone has objections > for this? I don't know if "objection" is the right word, but it seems to be a sub-optimal approach. Also, there's a real danger that the full functionality might never be achieved. On the other hand, it's better than nothing, and since there's also a real danger that nobody will do a full version anyway, I'm not going to take a position. Greg -- See complete headers for address and phone numbers