From owner-svn-src-head@FreeBSD.ORG Wed Apr 14 07:46:22 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CFA2106564A; Wed, 14 Apr 2010 07:46:22 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (chello089077043238.chello.pl [89.77.43.238]) by mx1.freebsd.org (Postfix) with ESMTP id CECC98FC12; Wed, 14 Apr 2010 07:46:20 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 51A7045CD9; Wed, 14 Apr 2010 09:46:18 +0200 (CEST) Received: from localhost (pdawidek.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 57C6345C9B; Wed, 14 Apr 2010 09:46:13 +0200 (CEST) Date: Wed, 14 Apr 2010 09:46:17 +0200 From: Pawel Jakub Dawidek To: Luigi Rizzo Message-ID: <20100414074616.GA1657@garage.freebsd.pl> References: <201004121637.o3CGbjSK080066@svn.freebsd.org> <20100412204926.GB1743@garage.freebsd.pl> <20100412210512.GB94885@onelab2.iet.unipi.it> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline In-Reply-To: <20100412210512.GB94885@onelab2.iet.unipi.it> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: svn-src-head@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r206497 - in head: sbin/geom/class sbin/geom/class/sched sys/geom/sched sys/modules/geom sys/modules/geom/geom_sched sys/modules/geom/geom_sched/gs_sched sys/modules/geom/geom_sched/gsc... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 07:46:22 -0000 --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 12, 2010 at 11:05:12PM +0200, Luigi Rizzo wrote: > On Mon, Apr 12, 2010 at 10:49:26PM +0200, Pawel Jakub Dawidek wrote: > ... > > > @@ -0,0 +1,19 @@ > > > +# GEOM_LIBRARY_PATH > > > +# $FreeBSD$ > > > + > > > +.PATH: /usr/src/sbin/geom/misc > > > + > > > +CFLAGS +=3D -I/usr/src/sbin/geom > >=20 > > This doesn't look right. >=20 > probably a leftover from older versions of this code for 6.x . > I will do more tests tomorrow (for 7.x at this point, there is > no point in trying to support 6.x I believe) and try to remove > it if not necessary. As Rui said you should use ${.CURDIR} instead of hardcoding /usr/src/. BTW. So you decided to implement insert/remove functionality after all. I have some questions: - It is implemented as internal gsched hack, which is a pity, because this might be very useful functionality for other classes in the future. Is there a plan to make it more general and move it to the GEOM itself? - Why g_sched_flush_pending() operates on global structure? I think it will break if you try to insert and remove at the same time. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkvFcsgACgkQForvXbEpPzSgTQCgk300EKdL36NzV2dwl5K2E59L cA0AoMICf8zhh4mTBF6i9i4Gh5f1jD5t =W8nO -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--