From owner-svn-ports-all@freebsd.org Fri Jan 17 21:04:57 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30FD41FAB43; Fri, 17 Jan 2020 21:04:57 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47ztqX1j1xz45YJ; Fri, 17 Jan 2020 21:04:56 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 35E6433E20; Fri, 17 Jan 2020 16:04:55 -0500 (EST) Received: from anthias (simmu1-65-185.utaonline.at [62.218.65.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id 4E99833E1E; Fri, 17 Jan 2020 16:04:54 -0500 (EST) Date: Fri, 17 Jan 2020 22:04:52 +0100 (CET) From: Gerald Pfeifer To: Greg Lewis cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r509856 - head/java/openjdk12 In-Reply-To: <201908252055.x7PKtK8J082236@repo.freebsd.org> Message-ID: References: <201908252055.x7PKtK8J082236@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 47ztqX1j1xz45YJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-4.31 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.01)[ip: (-7.00), ipnet: 209.68.0.0/18(-1.91), asn: 7859(-1.07), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2020 21:04:57 -0000 On Sun, 25 Aug 2019, Greg Lewis wrote: > Log: > Allow the JDK to be compiled with gcc. > Modified: head/java/openjdk12/Makefile > ============================================================================== > --- head/java/openjdk12/Makefile Sun Aug 25 20:28:47 2019 (r509855) > +++ head/java/openjdk12/Makefile Sun Aug 25 20:55:19 2019 (r509856) > @@ -41,12 +41,12 @@ MAKE_ENV= LANG="C" \ > CLASSPATH="" \ > JAVA_HOME="" \ > LD_LIBRARY_PATH="" \ > - CC=/usr/bin/cc \ > - CXX=/usr/bin/c++ \ > - MAKEFLAGS="" \ > - USE_CLANG=true > + CC=${CC} \ > + CXX=${CXX} \ > + CPP=${CPP} \ These three lines should not be necessary since Mk/bsd.ports.mk features MAKE_ENV+= PREFIX=${PREFIX} \ LOCALBASE=${LOCALBASE} \ CC="${CC}" CFLAGS="${CFLAGS}" \ CPP="${CPP}" CPPFLAGS="${CPPFLAGS}" \ LDFLAGS="${LDFLAGS}" LIBS="${LIBS}" \ CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \ Was there anything in your tests that made you add those? > -CONFIGURE_ENV= CC=/usr/bin/cc \ > - CXX=/usr/bin/c++ > +CONFIGURE_ENV= CC=${CC} \ > + CXX=${CXX} \ > + CPP=${CPP} Similarly here since configure is invoked with ${SETENV} CC="${CC}" CPP="${CPP}" CXX="${CXX}" ... in Mk/bsd.ports.mk. > +CONFIGURE_ARGS+= --disable-warnings-as-errors \ > + --disable-dtrace \ > + --with-extra-ldflags="-Wl,-rpath=${LOCALBASE}/lib/gcc${GCC_DEFAULT} -L/usr/local/lib/gcc${GCC_DEFAULT}" \ > + --with-extra-cflags="-Wl,-rpath=${LOCALBASE}/lib/gcc${GCC_DEFAULT}" \ > + --with-extra-cxxflags="-Wl,-rpath=${LOCALBASE}/lib/gcc${GCC_DEFAULT}" That should be in in CFLAGS, CXXFLAGS, and LDFLAGS as it is set by USE_GCC=yes. Is this not working properly? Gerald