From owner-freebsd-wireless@FreeBSD.ORG Thu Dec 1 00:05:29 2011 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id CED32106566C; Thu, 1 Dec 2011 00:05:29 +0000 (UTC) Date: Thu, 1 Dec 2011 00:05:29 +0000 From: Alexander Best To: freebsd-wireless@freebsd.org Message-ID: <20111201000529.GA47213@freebsd.org> References: <20111130224422.GA36424@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111130224422.GA36424@freebsd.org> Subject: Re: comparing floating points via "==" or "!=" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 00:05:29 -0000 On Wed Nov 30 11, Alexander Best wrote: > hi there, > > i played a bit with the gcc -Wfloat-equal warning and noticed that inside > sys/dev/ath/ath_rate/sample/tx_schedules.h, a lot of comparisons of floating > points are happening ("=="). is there a better way to deal with this? i just built GENERIC (incuding all modules) and this is the only place where direct comparisons of floating points happen. if this can be resolved, i vote that we add -Wfloat-equal to sys/conf/kern.mk:CWARNFLAGS. cheers. alex > > cheers. > alex