From owner-freebsd-ports@FreeBSD.ORG Thu Feb 10 15:21:42 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DACA106566B; Thu, 10 Feb 2011 15:21:42 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 455BA8FC1C; Thu, 10 Feb 2011 15:21:40 +0000 (UTC) Received: by wwf26 with SMTP id 26so1427106wwf.31 for ; Thu, 10 Feb 2011 07:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=3Wrd/HlKIJzkxC+9b1aNQjYi0jxsRaNm1939c1VVyAY=; b=ipwk4K8gflCdgLBs9RX1IAhasHtucp/tUKfuOGhlSPvGNAayqrT/8ucTSdNujp9H/4 tVOXJ8Try7XbA5leuU68NER7YuPt/OyEGlqx2RX8WMbyo2ZjZc4ToCznkk5uS6HQ06Xz +d3ivGfnr6a5CPlnllRt8r1IW1uIeG5RQBN8w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=mnJxFKU9Izwlp66WRxh3hWDAvZ2nypGI27XwdBWAO85P0Bcp7mr3QNoaxvO3l7xpAk A72eCzXY6J9Ur/Y2aR3y67UNsnMFo/y27qjJ+fNUVz+HyjyAmMoisdzqR5KGMaxGyLFg PLO4oaQ4qICV1PwB1dUO87xt3TERNIZwRRp64= Received: by 10.227.129.79 with SMTP id n15mr3111879wbs.134.1297351299865; Thu, 10 Feb 2011 07:21:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.227.69.140 with HTTP; Thu, 10 Feb 2011 07:21:17 -0800 (PST) In-Reply-To: <20110210143506.GA66529@bonjour.sunpoet.net> References: <20110209161008.GD87684@bonjour.sunpoet.net> <20110210143506.GA66529@bonjour.sunpoet.net> From: arrowdodger <6yearold@gmail.com> Date: Thu, 10 Feb 2011 18:21:17 +0300 Message-ID: To: Sunpoet Po-Chuan Hsieh , freebsd-ports@freebsd.org Content-Type: multipart/mixed; boundary=0016e65aee98609eb2049bef2354 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2011 15:21:42 -0000 --0016e65aee98609eb2049bef2354 Content-Type: text/plain; charset=UTF-8 On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh wrote: > On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote: > > I've updated port. The only thing left - setting dependency on py-gobject > by > > USE_GNOME variable. > > But if i run pkg_info -f on installed port, i see: > > > > > Dependency: py26-gobject-2.26.0 > > > dependency origin: devel/py-gobject > > > > > So, maybe this dependency is implicit and i should not care? > > Obviously USE_GNOME does not support devel/py-gobject now. All you can > do is to use BUILD_DEPENDS/RUN_DEPENDS. > > Your pkg_info result indicates that you've installed gobject, but it > means nothing to users of this port. The ports infrastructure generates > dependency list according to the Makefile. If py-gobject is required, > add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will > not be installed. > > > Updated port can be obtained here: > > http://intara.org.ru/tortoisehg1.shar > > or from attachment. > > Some comments: > - PORTNAME can be different with the path. PORTNAME=tortoisehg is OK. > - We usually use "USE_PYTHON=yes" > - It would be better to keep patches in *-patch: targets. > Move "${REINPLACE_CMD}" actions to post-patch:. > - If this port does not need to run configure or so. Use > do-configure: > @${DO_NADA} > > Regards, > Done. How should i submit new port? Open an PR? --0016e65aee98609eb2049bef2354--