From nobody Tue Jan 13 16:27:27 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drF5X0WF3z6NMRN for ; Tue, 13 Jan 2026 16:27:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drF5W4qTGz3Ktf for ; Tue, 13 Jan 2026 16:27:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768321647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vQ4txAuqxQr0q7NBS1oS/nt+yQTyqQhO+6JWhfQfhFQ=; b=wQNnfo5boa9/rnGH8QPbQXzLkkrlMzGH8DKnjRZ81EsyRsbrrgNJJLdBcb5YnTZzSrSJ84 yAi0e4XDKnV/vS8Rr0bDFNbpakJMK+Igt7IAR/mhZp2i3NMMhQyayLzcO9nOEU6ibkA7kH 8Mvt3omaAoNKpeV6j39YLTripseXRJGfBMEJgwIhQRoirXFUeUp2fCNA/0e3CVyu4sQ43f ro+VI1Ah30hSCECcoaHvXp85lZSQIc+Hp0KYDcF7tAz6HF8EfQHbXcZhUGTs0fwFg8VScj wcuxxU95z69c54tVex/IAkCqwGYt5bb5unTPMWddaVdp9m9+TW1QikE3jl87tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768321647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vQ4txAuqxQr0q7NBS1oS/nt+yQTyqQhO+6JWhfQfhFQ=; b=GvjLyjvjdl1GshfabzcJ0MKtshQl1nRZxTLVfLNTp7ZrDw3z6Q+fk9/y2GFU9XALe6LpYL BdcBttnDWkuYyDkORKQxqoA7ikGS1mTL4hFHGaAmPlhk/tnXXRX7XwxERwXs4+bAXTKFD1 9Nk+hznh9mPnyh6jDKitF4KsuFnW4t29TN7q2p/ZN/WIEpsoxFv7gkLw7K0Qh5JHBzbizT uHJWFfVENv15PzjvWqFZ8ut69ugh1GTmA/mvUnesQueBUy/PwYrcyLmsvy2NNPY0e4Lpx3 1ihcwb+MV2inlgRcvgEBhIlZxrxwmP62QQm+LagmGdiiwnZaw3uNouDkduOEww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768321647; a=rsa-sha256; cv=none; b=GKXAld15Xz2lnbFwGYNqkfG1vLDNsMeb7/jOTpuTfDpQofPJoU9t9Q+IlvcGnehP/BsenW kdYve+/IyFWKK9mw3jGpuoRYRu01r1XHjWAuyFfu7M0U4EZElP6SMsECXRdazKiO465pI/ ImWyCAuYhmq9oZFPAoR+zMf8woS/fL/jBoaO8IkXlu3K6Yv+IBSTaTCS6TZm3uLHfxI19i /qPeDtbl3w7EJkg6Nmkyb1D2ELNoF+6E4q6IWaQ7Wd+3OUITFzAdEcfOq7C0Yf7pLOR8LD 2zQfkdq8jFi1j1qSk4umUtdmY/oauwFUG3TBJP2OBYUSaVC1aAaCcmLtYKzLKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4drF5W4L2lz484 for ; Tue, 13 Jan 2026 16:27:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30511 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 13 Jan 2026 16:27:27 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrew Turner Subject: git: 6094ce4011f8 - stable/15 - pci/n1sdp: Disable HotPlug List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6094ce4011f83d606393c1a340ab29921a625c7e Auto-Submitted: auto-generated Date: Tue, 13 Jan 2026 16:27:27 +0000 Message-Id: <6966726f.30511.70acd49d@gitrepo.freebsd.org> The branch stable/15 has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=6094ce4011f83d606393c1a340ab29921a625c7e commit 6094ce4011f83d606393c1a340ab29921a625c7e Author: Andrew Turner AuthorDate: 2025-10-17 15:02:19 +0000 Commit: Andrew Turner CommitDate: 2026-01-13 14:06:19 +0000 pci/n1sdp: Disable HotPlug Work around an issue when HotPlug is enabled where pcib3 and pcib5 continuously report the following: pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed ... As a workaround disable HotPlug on the N1SDP as it's unlikely anyone will depend on it. Reviewed by: br Fixes: 1f5c50a86173 ("pci_host_generic:Add pcib_request_feature on ACPI") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D53134 (cherry picked from commit edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0) --- sys/dev/pci/controller/pci_n1sdp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/dev/pci/controller/pci_n1sdp.c b/sys/dev/pci/controller/pci_n1sdp.c index 487041bc78e4..22f0ea27d45b 100644 --- a/sys/dev/pci/controller/pci_n1sdp.c +++ b/sys/dev/pci/controller/pci_n1sdp.c @@ -345,6 +345,17 @@ n1sdp_pcie_write_config(device_t dev, u_int bus, u_int slot, bus_space_write_4(t, h, offset & ~3, data); } +static int +n1sdp_pcie_acpi_request_feature(device_t pcib __unused, device_t dev __unused, + enum pci_feature feature __unused) +{ + /* + * HotPlug isn't supported on the N1SDP as it causes an interrupt storm + */ + return (EINVAL); +} + + static device_method_t n1sdp_pcie_acpi_methods[] = { DEVMETHOD(device_probe, n1sdp_pcie_acpi_probe), DEVMETHOD(device_attach, n1sdp_pcie_acpi_attach), @@ -352,6 +363,7 @@ static device_method_t n1sdp_pcie_acpi_methods[] = { /* pcib interface */ DEVMETHOD(pcib_read_config, n1sdp_pcie_read_config), DEVMETHOD(pcib_write_config, n1sdp_pcie_write_config), + DEVMETHOD(pcib_request_feature, n1sdp_pcie_acpi_request_feature), DEVMETHOD_END };