From owner-svn-src-head@freebsd.org Sun Mar 12 23:54:43 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A712D09652 for ; Sun, 12 Mar 2017 23:54:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 17D6A1D9D; Sun, 12 Mar 2017 23:54:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x243.google.com with SMTP id j5so17153300pfb.3; Sun, 12 Mar 2017 16:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=2oJRRwa7WJ8R3N0B0WJMrkilT57hDT76Ai7Axc38DBQ=; b=GkvHDDZYLfB/NeHhUHmyFQeVYauBq8LFrU33gl1C/BdG7QT+lRLHBittRq5+CD0kfY nXYCPN7Wh0r+NaYbW1QJWq5VWzSrPvdcl7XrTyZDWhcWl+t2MdQfVDdej7pnsRygDM1+ CPaotm4zFpWsVu56Bhd8h+dnvSxLtSpI8ikiRcTWrJIny7MmqxKaC+XJr9ucyCSIvsSR 3Pq27/nQI4LNDwEuqyweSyBH63Cb+8amuqAlyoOTEw1F6bMTVM+50mvtwun0il94y/r6 kFki/jiaI08oSJsbSPsp9CglYyXPmmrdGH9o9Mh6wCGOo0I36HpIaCfsmRYjEpz70Gyi 8fXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=2oJRRwa7WJ8R3N0B0WJMrkilT57hDT76Ai7Axc38DBQ=; b=XiwpmcmPp5JudhZBHC+/E2Mvay2ZPTAWrm244saw3Ys6G/Wk+IXAfWq1UOUAsa2ZEL MP845oD3U28vHO509CaZdnJkD+DGmTQbi9uGCeuOCakBsSh/xzNM/T4S+SRoPLuzEm0J G96Hm/KNiLbRbUuZkqnLrtfCDnG2mvdzKDkWhMPob0NdCNVsO//Gev2aC2ACxhAdLPn0 Nxai+11lw5+RgXil/ubfBncOK9q5NLfJCDpBM9RYKX976PY0cVT6DySGfzGyg4VkJmyM Pg35bt1jxIJxvuZPoZvPdAHdVtuDEsWf014CZbxQy0Y08B+n0yDT7ms65qxOppvySF9V F3zQ== X-Gm-Message-State: AMke39kws4uI8ZlKl5hW2TFCZJ4F0XOnMOfS6twl4YB5dTdUvJF9lFJ6/m8WcQc6Of8LRg== X-Received: by 10.99.65.1 with SMTP id o1mr33366573pga.93.1489362882576; Sun, 12 Mar 2017 16:54:42 -0700 (PDT) Received: from ?IPv6:2607:fb90:8118:3a44:8ef:a92a:b7c7:1e88? ([2607:fb90:8118:3a44:8ef:a92a:b7c7:1e88]) by smtp.gmail.com with ESMTPSA id t12sm29987826pfg.14.2017.03.12.16.54.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Mar 2017 16:54:41 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Ngie Cooper Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r314780 - head/lib/libpam/modules/pam_exec Date: Sun, 12 Mar 2017 16:54:22 -0700 Message-Id: References: <201703061545.v26FjkNI027057@repo.freebsd.org> <739617a4-3eed-28d1-73e4-86d25d6d5fed@freebsd.org> <1839903b-fb05-bf3f-17bb-697afca9ecb7@FreeBSD.org> <1489341856.40576.88.camel@freebsd.org> Cc: Pedro Giffuni , Lawrence Stewart , src-committers@freebsd.org, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , svn-src-head@freebsd.org In-Reply-To: <1489341856.40576.88.camel@freebsd.org> To: Ian Lepore X-Mailer: iPhone Mail (14D27) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Mar 2017 23:54:43 -0000 > On Mar 12, 2017, at 11:04, Ian Lepore wrote: ... > A quirk of C that's often forgotten is that a function-like macro is > only expanded as a macro if the token following the macro name is an > open paren. So nitems() is a macro invokation and nitems =3D 0; is just > a variable. >=20 > I'm not arguing against the replacement of variables named nitems, I > actually think that should have been done as part of importing the > function-like definition of nitems from netbsd. Minor correction (as Pedro noted later): - NetBSD uses __arraycount. - OpenBSD uses nitems. FreeBSD has standardized on nitems, probably because it came about in 8.x, w= hereas __arraycount came about later. Cheers, -Ngie=