From owner-cvs-all@FreeBSD.ORG Sun Jun 20 01:40:55 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 680) id F0F3516A4D0; Sun, 20 Jun 2004 01:40:54 +0000 (GMT) Date: Sun, 20 Jun 2004 01:40:54 +0000 From: Darren Reed To: Doug Rabson Message-ID: <20040620014054.GA63575@hub.freebsd.org> References: <200406171523.i5HFNpjs011498@repoman.freebsd.org> <20040618143127.GP9228@elvis.mu.org> <20040619071754.GA73529@VARK.homeunix.com> <200406190958.43804.dfr@nlsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406190958.43804.dfr@nlsystems.com> User-Agent: Mutt/1.4.1i cc: Max Laier cc: Maxime Henrion cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org cc: Dag-Erling Sm?rgrav cc: David Schultz Subject: Re: cvs commit: src/contrib/pf/pfctl pfctl_parser.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jun 2004 01:40:55 -0000 On Sat, Jun 19, 2004 at 09:58:43AM +0100, Doug Rabson wrote: > On Saturday 19 June 2004 08:17, David Schultz wrote: > > On Fri, Jun 18, 2004, Maxime Henrion wrote: > > > Dag-Erling Sm?rgrav wrote: > > > > Max Laier writes: > > > > > Log: > > > > > Fix printing of u_int64_t with a cast to unsigned long long. > > > > > > > > The correct fix is to cast it to uintmax_t and print it with %ju. > > > > > > Using %llu and a cast to (unsigned long long) is as correct as > > > using uintmax_t and %ju because the C99 standard says that "long > > > long" is at least 64-bit wide. We generally use {u,}intmax_t in > > > FreeBSD because it works in more cases, but in that case we can't > > > because OpenBSD doesn't have intmax_t. > > > > /me wonders how much backpedaling we'll wind up doing on the > > uintmax_t casts when someone decides to add uint128_t to gcc > > and uintmax_t becomes painfully slow on 32-bit arches. ;-) > > Gcc already has uint128_t. I use it all the time on PS2 and something > like it is used on x86 for SSE... That's nice! Finally a native type for putting IPv6 addresses in! Darren