From owner-cvs-src@FreeBSD.ORG  Thu Oct  2 22:42:57 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C8290106568E;
	Thu,  2 Oct 2008 22:42:57 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 885F08FC17;
	Thu,  2 Oct 2008 22:42:57 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m92MdnZX092146;
	Thu, 2 Oct 2008 16:39:50 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Thu, 02 Oct 2008 16:40:41 -0600 (MDT)
Message-Id: <20081002.164041.-345492472.imp@bsdimp.com>
To: jhb@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200810021305.47479.jhb@freebsd.org>
References: <200810020629.m926TqZq036159@repoman.freebsd.org>
	<200810021305.47479.jhb@freebsd.org>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/pccbb pccbb_pci.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Oct 2008 22:42:57 -0000

In message: <200810021305.47479.jhb@freebsd.org>
            John Baldwin <jhb@freebsd.org> writes:
: On Thursday 02 October 2008 02:29:45 am Warner Losh wrote:
: > imp         2008-10-02 06:29:45 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/dev/pccbb        pccbb_pci.c 
: >   Log:
: >   SVN rev 183539 on 2008-10-02 06:29:45Z by imp
: >   
: >   Don't forget to match on a CLASS of PCIC_BRIDGE as well as subclass
: >   PCIS_BRIDGE_CARDBUS.  Otherwise, we may hit a few false positives....
: 
: Shouldn't it use BUS_GENERIC_PROBE instead of BUS_DEFAULT_PROBE when matching 
: purely on the class codes?

Yes.  I'll fix it.

Warner