From owner-svn-src-head@freebsd.org Tue Apr 26 01:15:21 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DCB5B1D7A2; Tue, 26 Apr 2016 01:15:21 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 628FB19F5; Tue, 26 Apr 2016 01:15:21 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-oi0-x234.google.com with SMTP id r78so179264oie.0; Mon, 25 Apr 2016 18:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc; bh=Q67c6MNe9J5YYvYq3LSOice4oKqX5O26q9aQ72pyNOo=; b=Xc/PLVnqSTXAQXB7qLtez7kqpDcR9rGqLfTjwACOOiHWxgarnVkfoqItZGexJT2jaM 3+aR1d9R9EB+xmgE24BylbypgpH01iTErygC93pThHh+xy/AyW/v4BitAyNU6FVpLneT zmsomj1Wq/1kZSvxrQG38mPukdbWhGTP5+CwuM8aB2rjiscmjd1INJG8uvFc2YHbkMVu cpIc6EgzYokTNJ3AHDWt6FptyYOzE0AAOlGixWePuYm7DZKr+Z+lTe3xbf+2NtfCYCs+ 6wlRU0FNfvuaQGLWW4c81WlJ46udQc68/03zL93qJLrq4Lh8P23bcDDKaZjlSsI6+9C6 i9Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=Q67c6MNe9J5YYvYq3LSOice4oKqX5O26q9aQ72pyNOo=; b=SCzRKh467T67C4Bvti1t2/fS9L4yJ1mry2Y640SDOClPAziEBD0qje7d6ptCzMYriv BFMV+oe5hRNjHM3+o3pXy01qQbneaPUugnHhpVxnDIFzU8yq+zeI3jo+PAmJRlsUPA7+ jcO5pQbLi6AoDTD7N8i9HQFVTGAhD6a3OZMtLZYBBwWP3Ig8y7yQCEUTUm2/qmqrfLX5 /5btFfcdyphrG/125jzm/Zn4IPHu9o99aOXc8CH3dNzgfa6RLo23LLxO0oalP2BKI7F+ ULKFQVxO5D3ZVHSD/9I/A81tU7e9ibZ9wacLhz8THbcoKVQOgBGMVfArnUoX/my6Zcrr Xyiw== X-Gm-Message-State: AOPr4FVGNyfxrUD2/12+WcfHQtuXORp3i0Cg1jZVobNLWi9Do7iXguaf4b49OY69dzpk+O/UPc5mUocq89By2A== MIME-Version: 1.0 X-Received: by 10.157.3.97 with SMTP id 88mr17289050otv.137.1461633320737; Mon, 25 Apr 2016 18:15:20 -0700 (PDT) Received: by 10.182.156.65 with HTTP; Mon, 25 Apr 2016 18:15:20 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: <69810c2f-ee32-5d7b-8367-689b2afb0d97@FreeBSD.org> References: <201604220343.u3M3h69m058753@repo.freebsd.org> <69810c2f-ee32-5d7b-8367-689b2afb0d97@FreeBSD.org> Date: Tue, 26 Apr 2016 09:15:20 +0800 Message-ID: Subject: Re: HEADS UP: I will revert this. (was Re: svn commit: r298443 - head/usr.bin/stat) From: Marcelo Araujo To: Pedro Giffuni Cc: "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2016 01:15:21 -0000 2016-04-26 5:33 GMT+08:00 Pedro Giffuni : > Hi Marcelo; > > Hi; > > I assume you have been very busy. > > I will revert this in a couple of hours unless you either explain > or revert it yourself. > Fixed! Sorry my delay, I got a bit busy! Thanks for the hands up. > > Pedro. > > On 04/23/16 04:23, luke wrote: > >> On Fri, Apr 22, 2016 at 11:43 AM, Marcelo Araujo > > wrote: >> >> Author: araujo >> Date: Fri Apr 22 03:43:06 2016 >> New Revision: 298443 >> URL: https://svnweb.freebsd.org/changeset/base/298443 >> >> Log: >> Use macro MAX() from sys/param.h. >> >> MFC after: 2 weeks. >> >> Modified: >> head/usr.bin/stat/stat.c >> >> Modified: head/usr.bin/stat/stat.c >> >> ============================================================================== >> --- head/usr.bin/stat/stat.c Fri Apr 22 03:37:27 2016 >> (r298442) >> +++ head/usr.bin/stat/stat.c Fri Apr 22 03:43:06 2016 >> (r298443) >> @@ -1025,7 +1025,7 @@ format1(const struct stat *st, >> * >> * Nanoseconds: long. >> */ >> - (void)snprintf(tmp, sizeof(tmp), "%dld", prec > 9 ? >> 9 : prec); >> + (void)snprintf(tmp, sizeof(tmp), "%dld", MAX(9, >> prec)); >> (void)strcat(lfmt, tmp); >> >> /* >> _______________________________________________ >> svn-src-head@freebsd.org mailing >> list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to >> "svn-src-head-unsubscribe@freebsd.org >> " >> >> >> >> Hi, >> >> Should this be MIN() ? >> >> (void)snprintf(tmp, sizeof(tmp), "%dld", MIN(prec, 9)); >> >> >> -- >> Chang-Hsien Tsai >> >> -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)