From owner-cvs-src@FreeBSD.ORG Wed May 14 01:11:07 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5FDE37B401; Wed, 14 May 2003 01:11:06 -0700 (PDT) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8E30643F75; Wed, 14 May 2003 01:11:04 -0700 (PDT) (envelope-from grog@lemis.com) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id CA14C51A7C; Wed, 14 May 2003 17:40:41 +0930 (CST) Date: Wed, 14 May 2003 17:40:41 +0930 From: Greg 'groggy' Lehey To: Poul-Henning Kamp Message-ID: <20030514081041.GD4390@wantadilla.lemis.com> References: <20030512230725.GB28486@wantadilla.lemis.com> <17530.1052803678@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yudcn1FV7Hsu/q59" Content-Disposition: inline In-Reply-To: <17530.1052803678@critter.freebsd.dk> User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2003 08:11:07 -0000 --yudcn1FV7Hsu/q59 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tuesday, 13 May 2003 at 7:27:58 +0200, Poul-Henning Kamp wrote: > In message <20030512230725.GB28486@wantadilla.lemis.com>, "Greg 'groggy' Lehey" > writes: >> >> --ESr4fftwSwE2Rzwi >> Content-Type: text/plain; charset=us-ascii >> Content-Disposition: inline >> >> On Monday, 12 May 2003 at 13:15:29 -0700, Poul-Henning Kamp wrote: >>> phk 2003/05/12 13:15:29 PDT >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/geom geom_disk.c >>> Log: >>> When a disk disappears, destroy the class from the event thread >>> to avoid race condtion. >> >> Was this the cause of a panic while mallocing 16 bytes? > > I don't think so. > > Where is that panic reported ? I haven't reported it yet because I was in the middle of debugging my own mess. Here's what happens when I remove a disk while accessing a Vinum volume on it: (da1:sym0:0:1:0): lost device (da1:sym0:0:1:0): Invalidating pack <6>vinum: miniraid.p0.s1 is crashed by force <6>vinum: miniraid.p0 is degraded malloc() of "16" with the following non-sleepablelocks held: exclusive sleep mutex g_xup r = 0 (0xc8612ca8) locked @ /src/FreeBSD/5-CURRENT-ZAPHOD/src/sys/geom/geom_io.c:363 <3> fatal:miniraid.p0.s1 read error, block 1902193 for 512 bytes <3>miniraid.p0.s1: user buffer block 3803808 for 65536 bytes <3>mytest2: fatal drive I/O error, block 1902193 for 512 bytes <6>vinum: drive mytest2 is down malloc() of "16" with the following non-sleepablelocks held: exclusive sleep mutex g_xup r = 0 (0xc8612ca8) locked @ /src/FreeBSD/5-CURRENT-ZAPHOD/src/sys/geom/geom_io.c:363 malloc() of "16" with the following non-sleepablelocks held: exclusive sleep mutex g_xup r = 0 (0xc8612ca8) locked @ /src/FreeBSD/5-CURRENT-ZAPHOD/src/sys/geom/geom_io.c:363 <118>May 13 17:19:23 zaphod kernel: vinum: miniraid.p0.s1 is crashed by force <118>May 13 17:19:23 zaphod kernel: vinum: miniraid.p0 is degraded <118>May 13 17:19:23 zaphod kernel: fatal:miniraid.p0.s1 read error, block 1902193 for 512 bytes <118>May 13 17:19:23 zaphod kernel: miniraid.p0.s1: user buffer block 3803808 for 65536 bytes <118>May 13 17:19:23 zaphod kernel: mytest2: fatal drive I/O error, block 1902193 for 512 bytes <118>May 13 17:19:23 zaphod kernel: vinum: drive mytest2 is down (da1:sym0:0:1:0): Synchronize cache failed, status == 0x5b, scsi status == 0x0 (da1:sym0:0:1:0): removing device entry panic: final g_dev_close() with outstanding bios After looking at it more carefully, the final panic is my problem. I don't know if it would have panicked otherwise. Greg -- See complete headers for address and phone numbers --yudcn1FV7Hsu/q59 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE+wfoBIubykFB6QiMRAkvoAJ9Z6cRiGDsm0i1coJePoBs3NJcLgwCdGLiJ DJePPRfG6ktmdcKewIckCe0= =5kZm -----END PGP SIGNATURE----- --yudcn1FV7Hsu/q59--